Fix lobby registration label bug in rP19881
ClosedPublic
Actions

Authored by elexis on Aug 13 2017, 2:56 PM.

Details

Reviewers

Imarok

Commits

rP20012: Fix rP19881 bug that shows the "enter your password" label before the password…

Summary

rP19881 removed an 'else' in a huge if-else-if chain.
This however was relevant when starting without an existing user+pw combination in the user.cfg.
Now it inappropriatly shows "enter your password".

While at it, we wanted to update the string.
Don't mention any specific rules there, as they might be subject to change and the user
figures out which character isn't allowed easily.

Test Plan

Delete user.cfg, open the lobby.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Aug 13 2017, 2:56 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1850/ for more details.

Executing section Default...
Executing section Source...
Executing section JS...

binaries/data/mods/public/gui/lobby/prelobby.js
| 161| »   »   switch(message.level)·{
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/lobby/prelobby.js
| 221| »   switch(page)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/lobby/prelobby.js
| 153| »   while·((message·=·Engine.LobbyGuiPollMessage())·!=·undefined)
|    | [NORMAL] JSHintBear:
|    | Use '!==' to compare with 'undefined'.
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jw:8080/job/phabricator_lint/390/ for more details.

Harbormaster completed remote builds in B2782: Diff 3097.Aug 13 2017, 3:44 PM

elexis mentioned this in D770: Hide useless lobby password label and add translation context.Aug 18 2017, 3:58 PM

Closed by commit rP20012: Fix rP19881 bug that shows the "enter your password" label before the password… (authored by elexis). · Explain WhyAug 21 2017, 3:55 AM

This revision was automatically updated to reflect the committed changes.