Page MenuHomeWildfire Games

create elephant produce omnipresent sound

Authored by Stan on Aug 20 2017, 2:00 PM.



Since elephant templates used: actor/fauna/animal/elephant_trained.xml which isn't omnipresent and haven't any Heardby entry, it could be heard by every player with vision on the building that trained such an unit whenever the building is on the screen.
Now the elephant creation sound can be heard only by the owner and it is omnipresent, it means that the sound can be heard indipendently if you see the building on the screen.
Here is the sound originally named as elephant_trained1.ogg in actor/fauna/animal folder.

Test Plan

train an elephant and move the camera elsewhere to notice that the elephant creation sound can't be heard unlike the rest of the units.
apply the patch and try again in order to notice the difference.

Diff Detail

Lint Skipped
Unit Tests Skipped

Event Timeline

Grugnas created this revision.Aug 20 2017, 2:00 PM
bb added a subscriber: bb.Aug 29 2017, 6:47 PM

Can you manually upload the sound file? (phab is just messing up on binary files, so we gotta do it manually...)


Notice that most alarms have other values here, while animal sounds have these. Maybe someone with more experience on this should have a look.

Stan added a subscriber: Stan.Aug 29 2017, 6:54 PM

What did you change to the sound file ?

In D808#33211, @Stan wrote:

What did you change to the sound file ?

I only added those 2 entries:
(you can read the revision description).

In D808#33208, @bb wrote:

Can you manually upload the sound file? (phab is just messing up on binary files, so we gotta do it manually...)

that's a good point as far as i never manipulated audio applied to videogames. I am gonna upload the audio file

Grugnas edited the summary of this revision. (Show Details)Aug 29 2017, 8:29 PM
Stan added a comment.Aug 29 2017, 8:51 PM

@Grugnas Why does it say you modified the binary file ? Or did you add it ?

bb added a comment.Oct 22 2017, 5:00 PM

What about hero elephants?


IMO keep the codebase consistent and have all the alarms_create with the same values, so also this new one, so copy-pasta from some other create sound in the interface/alarm directory

Grugnas planned changes to this revision.Oct 28 2017, 3:50 PM

(You can grab @Pureon input about that.)

Stan added a reviewer: Stan.Sep 26 2019, 3:58 PM
Stan commandeered this revision.Sep 26 2019, 4:01 PM
Stan abandoned this revision.
Stan edited reviewers, added: Grugnas; removed: Stan.

This was fixed differently by D944