Page MenuHomeWildfire Games
Differential D809

Delete unappealing Modern Gray button
ClosedPublic
Actions

Authored by elexis on Aug 20 2017, 2:33 PM.

Details

Reviewers
None
Commits
rP20008: Delete unused, not too appealing Modern Gray button from rP17403.
Summary

This reverts rP17403. The button was added when the replay menu was committed with Stone themed buttons. The idea was that nothing should use the Stone buttons again.
IMO we can use Red buttons in the gamesetup and replay menu (should be considered in a separate patch though).
But the Stone buttons are definitely nicer than these Gray buttons which aren't used anywhere and noone asked for these buttons when they were committed.
It's the same story as the yellow buttons (see rP19993), just that they are less ugly and hadn't received any feedback because they were never used.

The Stone buttons are (and most probably will be continued to be) used in the main menu.

Test Plan

Notice that the buttons are not recommended to be used and currently unused.

Current:

Proposed to be deleted:

Possibly proposed for the future:

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Aug 20 2017, 2:33 PM
elexis edited the test plan for this revision. (Show Details)Aug 20 2017, 2:35 PM
Vulcan added a subscriber: Vulcan.Aug 20 2017, 4:08 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1886/ for more details.

Vulcan added a comment.Aug 20 2017, 4:09 PM
Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
|    | [INFO] XMLBear:
|    | XML can be formatted better.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/mod/gui/common/modern/styles.xml
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/mod/gui/common/modern/styles.xml
|   1|   1| <?xml version="1.0" encoding="utf-8"?>
|   2|    |-
|   3|   2| <styles>
|   4|   3| 	<!--
|   5|   4| 	==========================================
|    | [INFO] XMLBear:
|    | XML can be formatted better.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/mod/gui/common/modern/styles.xml
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/mod/gui/common/modern/styles.xml
|   7|   7| 	- be called by every object before any other style is loaded.
|   8|   8| 	==========================================
|   9|   9| 	-->
|  10|    |-	<style name="default"
|  11|    |-		absolute="false"
|  12|    |-		enabled="true"
|  13|    |-		ghost="false"
|  14|    |-		hidden="false"
|  15|    |-		size="0 0 100% 100%"
|  16|    |-		z="0"
|  17|    |-		font="sans-14"
|  18|    |-		buffer_zone="5"
|  19|    |-		multiline="false"
|  20|    |-	/>
|  21|    |-	<style name="ModernWindow"
|  22|    |-		sprite="ModernWindow"
|  23|    |-		buffer_zone="12"
|  24|    |-		text_align="left"
|  25|    |-		text_valign="top"
|  26|    |-	/>
|  27|    |-	<style name="ModernDialog"
|  28|    |-		sprite="ModernDialog"
|  29|    |-		buffer_zone="12"
|  30|    |-		text_align="left"
|  31|    |-		text_valign="top"
|  32|    |-	/>
|  33|    |-	<style name="ModernList"
|  34|    |-		buffer_zone="5"
|  35|    |-		font="sans-bold-stroke-14"
|  36|    |-		heading_height="25"
|  37|    |-		scrollbar="true"
|  38|    |-		scrollbar_style="ModernScrollBar"
|  39|    |-		sprite="ModernDarkBoxGoldNoTop"
|  40|    |-		sprite_selectarea="ModernDarkBoxWhite"
|  41|    |-		sprite_heading="ModernDarkBoxGoldNoBottom"
|  42|    |-		textcolor="white"
|  43|    |-		textcolor_selected="white"
|  44|    |-		text_align="left"
|  45|    |-		text_valign="center"
|  46|    |-		sound_selected="audio/interface/ui/ui_button_click.ogg"
|  47|    |-	/>
|  48|    |-	<style name="ModernSortedList"
|  49|    |-		buffer_zone="5"
|  50|    |-		font="sans-bold-stroke-14"
|  51|    |-		heading_height="25"
|  52|    |-		scrollbar="true"
|  53|    |-		scrollbar_style="ModernScrollBar"
|  54|    |-		sprite="ModernDarkBoxGoldNoTop"
|  55|    |-		sprite_selectarea="ModernDarkBoxWhite"
|  56|    |-		sprite_heading="ModernDarkBoxGoldNoBottom"
|  57|    |-		sprite_asc="ModernArrowUp"
|  58|    |-		sprite_desc="ModernArrowDown"
|  59|    |-		sprite_not_sorted="ModernNotSorted"
|  60|    |-		textcolor="white"
|  61|    |-		textcolor_selected="white"
|  62|    |-		text_align="left"
|  63|    |-		text_valign="center"
|  64|    |-		sound_selected="audio/interface/ui/ui_button_click.ogg"
|  65|    |-	/>
|  66|    |-	<style name="ModernDropDown"
|  67|    |-		dropdown_buffer="1"
|  68|    |-		font="sans-bold-14"
|  69|    |-		textcolor="white"
|  70|    |-		text_align="left"
|  71|    |-		text_valign="center"
|  72|    |-		button_width="16"
|  73|    |-		sprite="ModernDarkBoxGold"
|  74|    |-		sprite_disabled="ModernDarkBoxGoldDisabled"
|  75|    |-		sprite2="ModernDropDownArrow"
|  76|    |-		sprite2_disabled="ModernDropDownArrowDisabled"
|  77|    |-		sprite2_pressed="ModernDropDownArrowHighlight"
|  78|    |-		buffer_zone="8"
|  79|    |-		dropdown_size="224"
|  80|    |-		sprite_list="BlackBorderOnGray"
|  81|    |-		sprite_selectarea="ModernDarkBoxWhite"
|  82|    |-		textcolor_selected="white"
|  83|    |-		textcolor_disabled="140 140 140 255"
|  84|    |-		scrollbar="true"
|  85|    |-		scrollbar_style="ModernScrollBar"
|  86|    |-		sound_opened="audio/interface/ui/ui_button_click.ogg"
|  87|    |-		sound_closed="audio/interface/ui/ui_button_click.ogg"
|  88|    |-		sound_selected="audio/interface/ui/ui_button_click.ogg"
|  89|    |-	/>
|  90|    |-	<style name="ModernLabelText"
|  91|    |-		font="sans-bold-stroke-14"
|  92|    |-		textcolor="white"
|  93|    |-		textcolor_disabled="140 140 140 255"
|  94|    |-		text_align="center"
|  95|    |-		text_valign="center"
|  96|    |-	/>
|  97|    |-	<style name="ModernRightLabelText"
|  98|    |-		font="sans-bold-stroke-14"
|  99|    |-		textcolor="white"
| 100|    |-		textcolor_disabled="140 140 140 255"
| 101|    |-		text_align="right"
| 102|    |-		text_valign="center"
| 103|    |-	/>
| 104|    |-	<style name="ModernLeftLabelText"
| 105|    |-		font="sans-bold-stroke-14"
| 106|    |-		textcolor="white"
| 107|    |-		textcolor_disabled="140 140 140 255"
| 108|    |-		text_align="left"
| 109|    |-		text_valign="center"
| 110|    |-	/>
| 111|    |-	<style name="ModernTopLabelText"
| 112|    |-		font="sans-bold-stroke-14"
| 113|    |-		textcolor="white"
| 114|    |-		text_align="center"
| 115|    |-		text_valign="top"
| 116|    |-	/>
| 117|    |-	<style name="ModernLeftTopLabelText"
| 118|    |-		font="sans-bold-stroke-14"
| 119|    |-		textcolor="white"
| 120|    |-		text_align="left"
| 121|    |-		text_valign="top"
| 122|    |-	/>
| 123|    |-	<style name="ModernText"
| 124|    |-		font="sans-14"
| 125|    |-		textcolor="white"
| 126|    |-		text_align="left"
| 127|    |-		text_valign="top"
| 128|    |-		scrollbar="true"
| 129|    |-		scrollbar_style="ModernScrollBar"
| 130|    |-	/>
| 131|    |-	<style name="ModernTextPanel"
| 132|    |-		buffer_zone="8"
| 133|    |-		scrollbar="true"
| 134|    |-		scrollbar_style="ModernScrollBar"
| 135|    |-		textcolor="white"
| 136|    |-		text_align="left"
| 137|    |-		text_valign="center"
| 138|    |-		sprite="ModernDarkBoxGold"
| 139|    |-	/>
| 140|    |-	<style name="ModernInput"
| 141|    |-		sprite="ModernDarkBoxWhite"
| 142|    |-		sprite_selectarea="color:150 0 0"
| 143|    |-		textcolor="white"
| 144|    |-		textcolor_selected="white"
| 145|    |-	/>
| 146|    |-	<style name="ModernTickBox"
| 147|    |-		sprite="ModernTickOff"
| 148|    |-		sprite2="ModernTickOn"
| 149|    |-		sprite_disabled="ModernTickDisabledOff"
| 150|    |-		sprite2_disabled="ModernTickDisabledOn"
| 151|    |-		square_side="22"
| 152|    |-		sound_pressed="audio/interface/ui/ui_button_click.ogg"
| 153|    |-	/>
| 154|    |-	<style name="ModernSlider"
| 155|    |-		sprite="ModernSliderButton"
| 156|    |-		sprite_bar="ModernSliderLine"
| 157|    |-		button_width="20"
| 158|    |-		tooltip_style="sliderTooltip"
| 159|    |-	/>
| 160|    |-	<style name="ModernButtonRed"
| 161|    |-		sprite="ModernButtonRed"
| 162|    |-		sprite_disabled="ModernButtonRedDisabled"
| 163|    |-		sprite_over="ModernButtonRedOver"
| 164|    |-		sprite_pressed="ModernButtonRed"
| 165|    |-		font="sans-bold-stroke-14"
| 166|    |-		textcolor="white"
| 167|    |-		textcolor_disabled="210 210 210 160"
| 168|    |-		text_align="center"
| 169|    |-		text_valign="center"
| 170|    |-		sound_pressed="audio/interface/ui/ui_button_click.ogg"
| 171|    |-	/>
| 172|    |-	<style name="ModernTabButtonHorizontal"
| 173|    |-		sprite="ModernTabHorizontalBackground"
| 174|    |-		sound_pressed="audio/interface/ui/ui_button_click.ogg"
| 175|    |-	/>
| 176|    |-	<style name="ModernTabButtonVertical"
| 177|    |-		sprite="ModernTabHorizontalBackground"
| 178|    |-		sound_pressed="audio/interface/ui/ui_button_click.ogg"
| 179|    |-	/>
|    |  10|+	<style name="default" absolute="false" enabled="true" ghost="false" hidden="false" size="0 0 100% 100%" z="0" font="sans-14" buffer_zone="5" multiline="false"/>
|    |  11|+	<style name="ModernWindow" sprite="ModernWindow" buffer_zone="12" text_align="left" text_valign="top"/>
|    |  12|+	<style name="ModernDialog" sprite="ModernDialog" buffer_zone="12" text_align="left" text_valign="top"/>
|    |  13|+	<style name="ModernList" buffer_zone="5" font="sans-bold-stroke-14" heading_height="25" scrollbar="true" scrollbar_style="ModernScrollBar" sprite="ModernDarkBoxGoldNoTop" sprite_selectarea="ModernDarkBoxWhite" sprite_heading="ModernDarkBoxGoldNoBottom" te

http://jw:8080/job/phabricator_lint/419/ for more details.

Harbormaster completed remote builds in B2842: Diff 3200.Aug 20 2017, 4:09 PM
elexis mentioned this in D802: Simplify work in translation of tutorials.Aug 20 2017, 6:38 PM
mimo added a subscriber: mimo.Aug 20 2017, 7:51 PM

I've no strong opinions on the different choices, but fine to remove the unused one and your poposition for future looks to me better than the current one.

Closed by commit rP20008: Delete unused, not too appealing Modern Gray button from rP17403. (authored by elexis). · Explain WhyAug 20 2017, 8:03 PM
This revision was automatically updated to reflect the committed changes.
fatherbushido mentioned this in D912: Change mauryan healer hero inheritance.Sep 16 2017, 5:52 PM

Revision Contents
Changeset List

Diff 3219

View Options

ps/trunk/binaries/data/mods/mod/art/textures/ui/global/modern/button/gray-unselected-background.png

Loading...
View Options

ps/trunk/binaries/data/mods/mod/art/textures/ui/global/modern/button/gray-unselected-center-bottom.png

Loading...
View Options

ps/trunk/binaries/data/mods/mod/art/textures/ui/global/modern/button/gray-unselected-center-top.png

Loading...
View Options

ps/trunk/binaries/data/mods/mod/art/textures/ui/global/modern/button/gray-unselected-left-bottom.png

Loading...
View Options

ps/trunk/binaries/data/mods/mod/art/textures/ui/global/modern/button/gray-unselected-left-center.png

Loading...
View Options

ps/trunk/binaries/data/mods/mod/art/textures/ui/global/modern/button/gray-unselected-left-top.png

Loading...
View Options

ps/trunk/binaries/data/mods/mod/art/textures/ui/global/modern/button/gray-unselected-right-bottom.png

Loading...
View Options

ps/trunk/binaries/data/mods/mod/art/textures/ui/global/modern/button/gray-unselected-right-center.png

Loading...
View Options

ps/trunk/binaries/data/mods/mod/art/textures/ui/global/modern/button/gray-unselected-right-top.png

Loading...
View Options

ps/trunk/binaries/data/mods/mod/gui/common/modern/sprites.xml

Loading...
View Options

ps/trunk/binaries/data/mods/mod/gui/common/modern/styles.xml

Loading...
Wildfire Games · Phabricator