as the title say, the code has always been broken but was not noticed until D276
Details
Details
- Reviewers
- None
- Commits
- rP20025: AI stats modifications from techs and auras broken for templates
check that the values are now correctly modified
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1888/ for more details.
Comment Actions
Executing section Default... Executing section Source... Executing section JS... binaries/data/mods/public/simulation/ai/petra/mapModule.js | 48| » » let·isConnected·=·(territoryMap.data[k]·&·m.TERRITORY_BLINKING_MASK)·==·0; | | [NORMAL] JSHintBear: | | Use '===' to compare with '0'. binaries/data/mods/public/simulation/ai/common-api/shared.js | 473| » if·(·aMatch·!=·null·) | | [NORMAL] JSHintBear: | | Use '!==' to compare with 'null'. binaries/data/mods/public/simulation/ai/common-api/gamestate.js | 258| » » switch·(entity.check) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/simulation/ai/common-api/gamestate.js | 275| » » » switch·(type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/421/ for more details.
Comment Actions
the values are correctly modified.
tested with the D276 + the code bb provided in the comments of such diff.
Comment Actions
Executing section Default... Executing section Source... Executing section JS... binaries/data/mods/public/simulation/ai/petra/mapModule.js | 48| » » let·isConnected·=·(territoryMap.data[k]·&·m.TERRITORY_BLINKING_MASK)·==·0; | | [NORMAL] JSHintBear: | | Use '===' to compare with '0'. binaries/data/mods/public/simulation/ai/common-api/shared.js | 473| » if·(·aMatch·!=·null·) | | [NORMAL] JSHintBear: | | Use '!==' to compare with 'null'. binaries/data/mods/public/simulation/ai/common-api/gamestate.js | 258| » » switch·(entity.check) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/simulation/ai/common-api/gamestate.js | 275| » » » switch·(type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/422/ for more details.
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1890/ for more details.