Page MenuHomeWildfire Games

Move Replays from Tools & Options submenu to the main menu
ClosedPublic

Authored by Imarok on Aug 21 2017, 2:38 PM.

Details

Summary

Move the "Replays" button from the "Tools & Options" submenu to the main menu. This feature is often overseen by players, because it's hidden in "Tools & Options". Users who know about the replay menu use it very often, which justifies moving it into the main menu.

Test Plan

Check everything woprks and is well arranged. (especially in 0ad min res)

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
elexis added a comment.Oct 9 2017, 4:43 PM
In D820#37179, @Imarok wrote:

Ugh, didn't know we have a SP/MP filter :D

"Patch by Imarok" rP18111, #3436 ;-)

Imarok added a comment.Oct 9 2017, 4:45 PM
In D820#37186, @elexis wrote:
In D820#37179, @Imarok wrote:

Ugh, didn't know we have a SP/MP filter :D

"Patch by Imarok" rP18111, #3436 ;-)

Yeah, I guessed that could be one of my patches xD

elexis added a comment.Oct 9 2017, 4:47 PM

Oh, also I have a WIP patch rewriting the entire main menu to make it easier to add new main menu items.
It removes all the XML code, the need to hardcode the number of items in a function call and the need to hardcode 50% of the positions.
It adds a JS object that only specifies the titles and button functions.
Didn't continue to work on it after a day, but I might someday in case I ever get out the rmgen hell.
It would make both this patch easier and easier to add and later remove the second tutorial button requested by mimo.

Imarok added a comment.Oct 9 2017, 4:51 PM
In D820#37188, @elexis wrote:

Oh, also I have a WIP patch rewriting the entire main menu to make it easier to add new main menu items.
It removes all the XML code, the need to hardcode the number of items in a function call and the need to hardcode 50% of the positions.
It adds a JS object that only specifies the titles and button functions.
Didn't continue to work on it after a day, but I might someday in case I ever get out the rmgen hell.
It would make both this patch easier and easier to add and later remove the second tutorial button requested by mimo.

I thought about doing the same some minutes ago, but then came to the conclusion changing some numbers is faster for me.
(Your patch won't help anymore with this patch, because I already finished the mainmenu.xml part)

Imarok updated this revision to Diff 3867.Oct 9 2017, 5:30 PM

Move Replays to MP and SP. Move scenario editor to main menu

Vulcan added a comment.Oct 9 2017, 5:34 PM

Build is green

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jenkins-master:8080/job/phabricator/2109/ for more details.

Vulcan added a comment.Oct 9 2017, 5:35 PM
Executing section Default...
Executing section Source...
Executing section JS...

binaries/data/mods/public/gui/replaymenu/replay_filters.js
| 116| »   »   if·(index·==·0)
|    | [NORMAL] JSHintBear:
|    | Use '===' to compare with '0'.
Executing section XML GUI...
|    | [INFO] XMLBear:
|    | XML can be formatted better.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/pregame/mainmenu.xml
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/pregame/mainmenu.xml
|   1|   1| <?xml version="1.0" encoding="utf-8"?>
|   2|    |-
|   3|   2| <objects>
|   4|   3| 	<script file="gui/common/music.js"/>
|   5|   4| 	<script file="gui/common/functions_global_object.js"/>
|    | [INFO] XMLBear:
|    | XML can be formatted better.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/pregame/mainmenu.xml
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/pregame/mainmenu.xml
|  19|  19| 		</action>
|  20|  20| 
|  21|  21| 		<repeat count="5">
|  22|    |-			<object name="background[n]"
|  23|    |-				type="image"
|  24|    |-				hidden="true"
|  25|    |-				ghost="true"
|  26|    |-			/>
|    |  22|+			<object name="background[n]" type="image" hidden="true" ghost="true"/>
|  27|  23| 		</repeat>
|  28|  24| 
|  29|  25| 		<!--
|    | [INFO] XMLBear:
|    | XML can be formatted better.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/pregame/mainmenu.xml
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/pregame/mainmenu.xml
|  31|  31| 		- MAIN MENU - STATIC TOOLTIP WINDOW
|  32|  32| 		==========================================
|  33|  33| 		-->
|  34|    |-		<object name="pgToolTip"
|  35|    |-			style="TranslucentPanel"
|  36|    |-			type="text"
|  37|    |-			hidden="true"
|  38|    |-			size="100%-290 25 100% 140"
|  39|    |-			ghost="true"
|  40|    |-		/>
|    |  34|+		<object name="pgToolTip" style="TranslucentPanel" type="text" hidden="true" size="100%-290 25 100% 140" ghost="true"/>
|  41|  35| 
|  42|  36| 		<!--
|  43|  37| 		==========================================
|    | [INFO] XMLBear:
|    | XML can be formatted better.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/pregame/mainmenu.xml
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/pregame/mainmenu.xml
|  44|  44| 		- MAIN MENU - USER REPORT
|  45|  45| 		==========================================
|  46|  46| 		-->
|  47|    |-		<object
|  48|    |-			name="userReportDisabled"
|  49|    |-			size="100%-304 100%-154 100%-4 100%-4"
|  50|    |-			type="image"
|  51|    |-			style="userReportPanel"
|  52|    |-		>
|  53|    |-			<object
|  54|    |-				type="text"
|  55|    |-				style="userReportText"
|  56|    |-			>
|    |  47|+		<object name="userReportDisabled" size="100%-304 100%-154 100%-4 100%-4" type="image" style="userReportPanel">
|    |  48|+			<object type="text" style="userReportText">
|  57|  49| 				<attribute id="caption">
|  58|  50| 					<keep>[font="sans-bold-16"]</keep>
|  59|  51| 					<translate>Help improve 0 A.D.!</translate>
|    | [INFO] XMLBear:
|    | XML can be formatted better.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/pregame/mainmenu.xml
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/pregame/mainmenu.xml
|  76|  76| 			</object>
|  77|  77| 		</object>
|  78|  78| 
|  79|    |-		<object
|  80|    |-			name="userReportEnabled"
|  81|    |-			size="100%-304 100%-154 100%-4 100%-4"
|  82|    |-			type="image"
|  83|    |-			style="userReportPanel"
|  84|    |-		>
|  85|    |-			<object
|  86|    |-				name="userReportEnabledText"
|  87|    |-				type="text"
|  88|    |-				style="userReportText"
|  89|    |-			/>
|    |  79|+		<obje

http://jenkins-master:8080/job/phabricator_lint/582/ for more details.

elexis added inline comments.Oct 9 2017, 5:58 PM
binaries/data/mods/public/gui/replaymenu/replay_filters.js
38 ↗(On Diff #3867)

Why are the x in y checks needed?
If they are needed, are the ones coming afterwards unneeded?
unneeded parentheses

Imarok added inline comments.Oct 9 2017, 6:40 PM
binaries/data/mods/public/gui/replaymenu/replay_filters.js
38 ↗(On Diff #3867)

x in y checks are needed because I used a incomplete replaySelectionData.
Let's look into e.g. filters && ("mapSize" in filters) && filters.mapSize: filters checks for existence of filters, ("mapSize" in filters) for the existence of mapSize and fliters.mapSize actually retrieves the data.
unneeded parentheses may be true.

elexis added inline comments.Oct 9 2017, 6:44 PM
binaries/data/mods/public/gui/replaymenu/replay_filters.js
38 ↗(On Diff #3867)

Does JS actually complain if you pass x && x.y if x.y is undefined?

If not, nuke y in x.
If so, perhaps x && x.y || undefined or x ? x.y : undefined

Imarok added inline comments.Oct 9 2017, 8:38 PM
binaries/data/mods/public/gui/replaymenu/replay_filters.js
38 ↗(On Diff #3867)

Yes it does.
x && x.y || undefinedcould work.
I'll see.

Imarok updated this revision to Diff 3870.Oct 9 2017, 8:44 PM

Don't use y in x

Vulcan added a comment.Oct 9 2017, 8:49 PM

Build is green

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jenkins-master:8080/job/phabricator/2112/ for more details.

Vulcan added a comment.Oct 9 2017, 8:50 PM
Executing section Default...
Executing section Source...
Executing section JS...

binaries/data/mods/public/gui/replaymenu/replay_filters.js
| 116| »   »   if·(index·==·0)
|    | [NORMAL] JSHintBear:
|    | Use '===' to compare with '0'.
Executing section XML GUI...
|    | [INFO] XMLBear:
|    | XML can be formatted better.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/pregame/mainmenu.xml
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/pregame/mainmenu.xml
|   1|   1| <?xml version="1.0" encoding="utf-8"?>
|   2|    |-
|   3|   2| <objects>
|   4|   3| 	<script file="gui/common/music.js"/>
|   5|   4| 	<script file="gui/common/functions_global_object.js"/>
|    | [INFO] XMLBear:
|    | XML can be formatted better.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/pregame/mainmenu.xml
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/pregame/mainmenu.xml
|  19|  19| 		</action>
|  20|  20| 
|  21|  21| 		<repeat count="5">
|  22|    |-			<object name="background[n]"
|  23|    |-				type="image"
|  24|    |-				hidden="true"
|  25|    |-				ghost="true"
|  26|    |-			/>
|    |  22|+			<object name="background[n]" type="image" hidden="true" ghost="true"/>
|  27|  23| 		</repeat>
|  28|  24| 
|  29|  25| 		<!--
|    | [INFO] XMLBear:
|    | XML can be formatted better.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/pregame/mainmenu.xml
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/pregame/mainmenu.xml
|  31|  31| 		- MAIN MENU - STATIC TOOLTIP WINDOW
|  32|  32| 		==========================================
|  33|  33| 		-->
|  34|    |-		<object name="pgToolTip"
|  35|    |-			style="TranslucentPanel"
|  36|    |-			type="text"
|  37|    |-			hidden="true"
|  38|    |-			size="100%-290 25 100% 140"
|  39|    |-			ghost="true"
|  40|    |-		/>
|    |  34|+		<object name="pgToolTip" style="TranslucentPanel" type="text" hidden="true" size="100%-290 25 100% 140" ghost="true"/>
|  41|  35| 
|  42|  36| 		<!--
|  43|  37| 		==========================================
|    | [INFO] XMLBear:
|    | XML can be formatted better.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/pregame/mainmenu.xml
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/pregame/mainmenu.xml
|  44|  44| 		- MAIN MENU - USER REPORT
|  45|  45| 		==========================================
|  46|  46| 		-->
|  47|    |-		<object
|  48|    |-			name="userReportDisabled"
|  49|    |-			size="100%-304 100%-154 100%-4 100%-4"
|  50|    |-			type="image"
|  51|    |-			style="userReportPanel"
|  52|    |-		>
|  53|    |-			<object
|  54|    |-				type="text"
|  55|    |-				style="userReportText"
|  56|    |-			>
|    |  47|+		<object name="userReportDisabled" size="100%-304 100%-154 100%-4 100%-4" type="image" style="userReportPanel">
|    |  48|+			<object type="text" style="userReportText">
|  57|  49| 				<attribute id="caption">
|  58|  50| 					<keep>[font="sans-bold-16"]</keep>
|  59|  51| 					<translate>Help improve 0 A.D.!</translate>
|    | [INFO] XMLBear:
|    | XML can be formatted better.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/pregame/mainmenu.xml
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/pregame/mainmenu.xml
|  76|  76| 			</object>
|  77|  77| 		</object>
|  78|  78| 
|  79|    |-		<object
|  80|    |-			name="userReportEnabled"
|  81|    |-			size="100%-304 100%-154 100%-4 100%-4"
|  82|    |-			type="image"
|  83|    |-			style="userReportPanel"
|  84|    |-		>
|  85|    |-			<object
|  86|    |-				name="userReportEnabledText"
|  87|    |-				type="text"
|  88|    |-				style="userReportText"
|  89|    |-			/>
|    |  79|+		<obje

http://jenkins-master:8080/job/phabricator_lint/585/ for more details.

good maybe bringing replays in single player menu above load game and in multiplayer menu above lobby?

feeling little more convient.

greets

good maybe bringing replays in single player menu above load game and in multiplayer menu above lobby?

feeling little more convient.

greets

Good idea

Imarok updated this revision to Diff 4438.Nov 29 2017, 4:12 PM

Each one up

Wouldn't it be preferable to group the items that lead the player to the gamesetup? Meaning replay menu item always last. Just because we're used to the lobby being the last button doesn't mean we can't get used to a possibly more consistent order some days after the release.
(I really want to get that main menu diff in when I see the main menu changes)

binaries/data/mods/public/gui/pregame/mainmenu.xml
251 ↗(On Diff #4438)

The singleplayer filter name was always confusing, still likely better than some ambiguous type thing.
Correct call.

binaries/data/mods/public/gui/replaymenu/replay_filters.js
26 ↗(On Diff #4438)

Why not filters.compatibility, possibly !== undefined so that we have the same order (left to right) in the entire GUI?
Especially the last two conditions should become one where possible.

38 ↗(On Diff #3867)

x && x.y && x.y would work too. A bit retarded.
Still unhappy about those explicit warning mutes.

Why not just pass filters and let the function decide which property it needs (also helps with encapsulation).

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...
Executing section Default...
Executing section Source...
Executing section JS...
ffffffff added a comment.EditedDec 1 2017, 9:40 AM

Im feeling confortable now with the replay position. But im not getting along with the scenario editor in the mainmenu :( maybe back into options and make it back "Tools & Option" or "Options & Tools"? Or switching position Options and Scenario Editor?

Imarok updated this revision to Diff 4524.Dec 4 2017, 12:02 PM

Agree Scenario Editor above Options looks more natural

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...
Executing section Default...
Executing section Source...
Executing section JS...
elexis added a comment.Dec 4 2017, 1:06 PM

I still disagree with having Load Game below Replays. First we should have all actions that can start a game as a player, then the ones not starting a game as a player. So replays should be the last item in SP and MP, no?

wraitii added a subscriber: wraitii.Dec 4 2017, 2:03 PM

I still disagree with having Load Game below Replays. First we should have all actions that can start a game as a player, then the ones not starting a game as a player. So replays should be the last item in SP and MP, no?

Agreed.

In D820#43972, @elexis wrote:

I still disagree with having Load Game below Replays. First we should have all actions that can start a game as a player, then the ones not starting a game as a player. So replays should be the last item in SP and MP, no?

i dont know one people using load game :=)

its just personal opinion

replay much useful

we dont even have campaign to load in

also in multiplayer menu game action comes first join, host, replay then it comes lobby.

greetz

elexis added a comment.Dec 4 2017, 3:41 PM

i dont know one people using load game :=)

These players aren't on the forums and offline.

replay much useful

Having it at the 4th instead of 3rd button doesn't hide it. Players get used to it after clicking on it twice and players woh don't know about the feature (many currently) will notice it still quickly.

also in multiplayer menu game action comes first join, host, replay then it comes lobby.

The menus should receive the same order.

Not entirely strong disagreement, but it seems more logical to me to group them by that relation.
In case we ever get to MP savegame loading (sounds like gamesetup fun), that element would fit nicely above the MP replay button, below the lobby button.

maybe ok but icant along with accidently hitting scenario editor and exiting whole game replaced by another window.. maybe message box with start confirmation of scenario editor? actualy i liked many more having it little hidden. maybe should keep it in options?

actualy i liked many more having it little hidden. maybe should keep it in options?

No, just cause you don't use it doesn't mean everyone does not use it.

Imarok updated this revision to Diff 4598.Dec 6 2017, 12:50 PM

In SP: Load Game before Replays, as that is more important.

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...
Executing section Default...
Executing section Source...
Executing section JS...
ffffffff added a comment.EditedDec 6 2017, 1:13 PM
In D820#44521, @Imarok wrote:

actualy i liked many more having it little hidden. maybe should keep it in options?

No, just cause you don't use it doesn't mean everyone does not use it.

i not? and everyone to? Why is it now about what i use? Its just my opinion

elexis added inline comments.Dec 6 2017, 6:25 PM
binaries/data/mods/public/gui/replaymenu/replay_filters.js
38 ↗(On Diff #3867)

I'll see.

Did you?

Imarok updated this revision to Diff 4717.Dec 11 2017, 5:34 PM

only pass filters

Executing section Default...
Executing section Source...
Executing section JS...

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

"Replays" must become the last element in both SP and MP.

I am not confident anymore about the Atlas button. Users will have to be very careful not to click it (rather than the few pixel distanced Multiplayer or Options button), otherwise they kill the process unintentionally and unintentionally start another process that can't be killed until it finished loading!
Merely because of that I'd rather move the Atlas button just before Exit or keep the Tools & Options variant.

The "Welcome Screen" should become the last item (so that the three items that change things are grouped). If you want to do that in a separate reviewed or unreviewed but careful commit, I would appreciate that.

Options -> Options is a bit weird, maybe Configuration (since mods aren't an option technically?)

I believe Delenda Est, Terra Magna and many more mods can break as they provide an always outdated copy of this file, hooray. There are two opposing but maybe mergable ways described in D1080 to fix that.

binaries/data/mods/public/gui/pregame/mainmenu.xml
266 ↗(On Diff #4717)

}
}
});

520 ↗(On Diff #4717)

unneeded parentheses

binaries/data/mods/public/gui/replaymenu/replay_filters.js
26 ↗(On Diff #4438)

!filters || filters.compatibility !== false?

38 ↗(On Diff #3867)

Thanks, looks better

Imarok marked 3 inline comments as done.Dec 28 2017, 12:01 PM
In D820#47623, @elexis wrote:

I am not confident anymore about the Atlas button. Users will have to be very careful not to click it (rather than the few pixel distanced Multiplayer or Options button), otherwise they kill the process unintentionally and unintentionally start another process that can't be killed until it finished loading!
Merely because of that I'd rather move the Atlas button just before Exit or keep the Tools & Options variant.

Hmm, That makes sense

binaries/data/mods/public/gui/replaymenu/replay_filters.js
26 ↗(On Diff #4438)

nope, as this will error out when compatibility not defined

Imarok updated this revision to Diff 4981.Dec 28 2017, 12:02 PM

That what elexis said

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...
Executing section Default...
Executing section Source...
Executing section JS...
elexis added inline comments.Dec 28 2017, 5:23 PM
binaries/data/mods/public/gui/pregame/mainmenu.xml
345 ↗(On Diff #4981)

move to *.js

506 ↗(On Diff #4981)

The rename to Configuration and the Atlas button might be controversial. Maybe someone might complain perhaps under some circumstance. Could do a staff forum thread, but that might also get conflicting feedback that would end in a deadlock. To me the patch would be ok, but I don't want to be addressed in a flamewar. xd

binaries/data/mods/public/gui/replaymenu/replay_filters.js
26 ↗(On Diff #4438)

Would still prefer any "x.y operator z" form (i.e. || x.y === undefined if that above option truly errors out) since we use that order everywhere in the GUI. The reader should first read the subject, then the object.

Or how about this: actually specify the property instead of using a fallback.

I would suggest to commit this file excluding this line separately as reviewed by me. (I didn't test, but the matter is simple handcraft.)

Imarok updated this revision to Diff 5202.Jan 9 2018, 11:39 PM

minor tweaks (also one bugs fixed)

Imarok added inline comments.Jan 9 2018, 11:43 PM
binaries/data/mods/public/gui/pregame/mainmenu.xml
345 ↗(On Diff #4981)

Then I guess every onPress function should be in js?
-> so different diff...

506 ↗(On Diff #4981)

I also think it's ok, so we are two ;)

binaries/data/mods/public/gui/replaymenu/replay_filters.js
26 ↗(On Diff #4438)

Would still prefer any "x.y operator z" form (i.e. || x.y === undefined if that above option truly errors out) since we use that order everywhere in the GUI. The reader should first read the subject, then the object.

that seems working.

Or how about this: actually specify the property instead of using a fallback.

I would suggest to commit this file excluding this line separately as reviewed by me. (I didn't test, but the matter is simple handcraft.)

Why do you want to commit separately? (Where is the benefit?)

Executing section Default...
Executing section Source...
Executing section JS...

Looks nice. also still having maybe message box when clicking scenario editor to confirm close game and start scenario editor?

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

Looks nice. also still having maybe message box when clicking scenario editor to confirm close game and start scenario editor?

Hmm, that sounds like a good idea. (Could also be a follow up patch)

Imarok updated this revision to Diff 5385.Jan 20 2018, 11:35 AM

Add atlas confirmation window

elexis accepted this revision.Jan 22 2018, 3:14 PM
elexis added inline comments.
binaries/data/mods/public/gui/pregame/mainmenu.js
264 ↗(On Diff #5385)

start or open

binaries/data/mods/public/gui/pregame/mainmenu.xml
394 ↗(On Diff #5385)

who cares about the mod screen, should be moved to the bottom eventually

506 ↗(On Diff #4981)

Settings > Configuration > Options ?

binaries/data/mods/public/gui/replaymenu/replay_filters.js
26 ↗(On Diff #5385)

Even better would be always defining filters.compatibility if filters is defined

26 ↗(On Diff #4438)

Since it's unrelated cleanup. No need for a new revision. Splitting things makes it easier to digest for the reader, also easier to revert in case.

This revision is now accepted and ready to land.Jan 22 2018, 3:14 PM
This revision was automatically updated to reflect the committed changes.
Imarok marked 3 inline comments as done.