dont nerve sound messages user nick if return to lobby (from history)
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Event Timeline
Comment Actions
So the correct feature description would be "don't ping people if their nick appears in a historic lobby chat message?".
Use case seems correct. One receives an acoustic notification once, therefore is informed that there is a relevant message, even if one joins a game and returns to the lobby quickly, or restarts 0ad quickly.
But what if one is pinged while playing a game, then returns to the lobby? Then no sound is played - but there should, right?
Comment Actions
Agree that we don't want more than one sound per chat message.
But we should have at least one sound per chat message that contains the nick, so that we don't miss anything.
In case someone plays a game, is then pinged and then returns to the lobby, there won't be a ping (but it should inform the user that someone mentioned him while he was playing).
New Plan:
Once D819 is implemented, you will be able to distinguish between chat notifications that have been parsed at least once and ones that weren't parsed yet.
So don't use a JS global, but add a boolean to the "all messages" queue that indicates whether the chat message is a historic or new message and execute the ping accordingly.