Page MenuHomeWildfire Games

Fix 64-bit integer scriptconversions.
ClosedPublic

Authored by echotangoecho on Jan 23 2017, 6:43 PM.

Details

Summary

Fixes the behaviour of sending an 64-bit integer to JS which differed between Windows and Linux.

Test Plan

Should test whether the game builds & tests run on Linux 32-bit.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

echotangoecho created this revision.Jan 23 2017, 6:43 PM
Vulcan added a subscriber: Vulcan.Jan 23 2017, 7:26 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running debug tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/228/ for more details.

Itms awarded a token.Jan 25 2017, 11:45 PM
Itms rescinded a token.
Itms awarded a token.
Itms added a reviewer: Itms.Jan 25 2017, 11:48 PM
Itms added a subscriber: Itms.

Ha sorry for the token misclick (I really wanted to use that feature :P)

This works on Windows and I'll test that on 32-bit Linux tomorrow. Thanks for the patch!

Itms accepted this revision.Jan 30 2017, 11:16 AM

It does work on 32-bit Linux (Debian Jessie).

This revision is now accepted and ready to land.Jan 30 2017, 11:16 AM
This revision was automatically updated to reflect the committed changes.