Differential D849
Remove unneeded replay menu sprite Authored by elexis on Aug 30 2017, 2:22 PM.
Details
I'm not fully convinced of the necessity of the black background of the file location text field introduced D495. With the sprite:  Without the sprite:  Do a review.
Diff Detail
Event TimelineComment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files... http://jenkins-master:8080/job/phabricator/1936/ for more details. Comment Actions Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... | | [INFO] XMLBear: | | XML can be formatted better. |----| | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/replaymenu/replay_menu.xml | |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/replaymenu/replay_menu.xml | 1| 1| <?xml version="1.0" encoding="utf-8"?> | 2| |- | 3| 2| <objects> | 4| 3| | 5| 4| <!-- Used to display game info. --> | | [INFO] XMLBear: | | XML can be formatted better. |----| | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/replaymenu/replay_menu.xml | |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/replaymenu/replay_menu.xml | 3| 3| <objects> | 4| 4| | 5| 5| <!-- Used to display game info. --> | 6| |- <script file="gui/common/color.js" /> | 7| |- <script file="gui/common/functions_civinfo.js" /> | 8| |- <script file="gui/common/functions_utility.js" /> | | 6|+ <script file="gui/common/color.js"/> | | 7|+ <script file="gui/common/functions_civinfo.js"/> | | 8|+ <script file="gui/common/functions_utility.js"/> | 9| 9| <script file="gui/common/gamedescription.js"/> | 10| |- <script file="gui/common/settings.js" /> | | 10|+ <script file="gui/common/settings.js"/> | 11| 11| | 12| 12| <!-- Used to display message boxes. --> | 13| 13| <script file="gui/common/functions_global_object.js" /> | | [INFO] XMLBear: | | XML can be formatted better. |----| | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/replaymenu/replay_menu.xml | |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/replaymenu/replay_menu.xml | 10| 10| <script file="gui/common/settings.js" /> | 11| 11| | 12| 12| <!-- Used to display message boxes. --> | 13| |- <script file="gui/common/functions_global_object.js" /> | | 13|+ <script file="gui/common/functions_global_object.js"/> | 14| 14| | 15| 15| <!-- Used for engine + mod version checks and deleteTooltip. --> | 16| 16| <script file="gui/common/functions_utility_loadsave.js" /> | | [INFO] XMLBear: | | XML can be formatted better. |----| | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/replaymenu/replay_menu.xml | |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/replaymenu/replay_menu.xml | 13| 13| <script file="gui/common/functions_global_object.js" /> | 14| 14| | 15| 15| <!-- Used for engine + mod version checks and deleteTooltip. --> | 16| |- <script file="gui/common/functions_utility_loadsave.js" /> | | 16|+ <script file="gui/common/functions_utility_loadsave.js"/> | 17| 17| | 18| 18| <!-- Actual replay scripts after settings.js, as it initializes g_Settings. --> | 19| 19| <script file="gui/replaymenu/replay_menu.js" /> | | [INFO] XMLBear: | | XML can be formatted better. |----| | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/replaymenu/replay_menu.xml | |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/replaymenu/replay_menu.xml | 16| 16| <script file="gui/common/functions_utility_loadsave.js" /> | 17| 17| | 18| 18| <!-- Actual replay scripts after settings.js, as it initializes g_Settings. --> | 19| |- <script file="gui/replaymenu/replay_menu.js" /> | 20| |- <script file="gui/replaymenu/replay_actions.js" /> | 21| |- <script file="gui/replaymenu/replay_filters.js" /> | | 19|+ <script file="gui/replaymenu/replay_menu.js"/> | | 20|+ <script file="gui/replaymenu/replay_actions.js"/> | | 21|+ <script file="gui/replaymenu/replay_filters.js"/> | 22| 22| | 23| 23| <!-- Everything displayed in the replay menu. --> | 24| 24| <object type=" http://jenkins-master:8080/job/phabricator_lint/454/ for more details. |