Differential D85

Some small replaymenu gui fixes
ClosedPublic
Actions

Authored by Imarok on Jan 23 2017, 8:48 PM.

Details

Reviewers

elexis

Commits

rP19251: Some small replaymenu gui fixes

Trac Tickets

#3995

Summary

Correctly align the boxes and separator lines in the right panel.
Reduce the size of the scrollbars so that they don't overlap with the separator lines.
Better sizing of the mapinfo and the playerinfo boxes. (Fixes #3995)

Test Plan

Open the replaymenu and select a replay with a large mapinfo and playerinfo.
Look at it in minimal resolution and in fullscreen.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Imarok created this revision.Jan 23 2017, 8:48 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running debug tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/230/ for more details.

Harbormaster completed remote builds in B335: Diff 313.Jan 23 2017, 9:32 PM

Itms added a reviewer: elexis.Jan 25 2017, 11:48 PM

As mentioned in the ticket, can't actually reproduce the issue.

In D85#3431, @elexis wrote:

As mentioned in the ticket, can't actually reproduce the issue.

Me neither, though the Map Details window is too small anyway in min resolution

Following bb's reproduction, it seems to be a C++ GUI bug. So I don't like covering it up until we know more about the origins of the bug and find a way to reproduce it without the replay menu GUI.

In D85#3488, @elexis wrote:

Following bb's reproduction, it seems to be a C++ GUI bug. So I don't like covering it up until we know more about the origins of the bug and find a way to reproduce it without the replay menu GUI.

Could you reproduce it?
Because I tried and couldn't.

Tested too. Good patch, even if it likely doesn't fix bb's engine bug.

binaries/data/mods/public/gui/replaymenu/replay_menu.xml
149 ↗	(On Diff #313)	ok
207 ↗	(On Diff #313)	Good change going from 3% to 5px as we don't need more border for bigger screensizes. Horizontal rescaling is good too as there is way too few space on 1024x768 and the proposed size works well with resolutions far greater than 1920x1080 too
208 ↗	(On Diff #313)	That 1px change works indeed:
214 ↗	(On Diff #313)	Having a custom GUI object for the players label and another for the nr of players is bad, it should be one GUI object spannign across the entire line, so it's always horizontally centered, even with 348576 players (refs #4004), but not relevant for this patch. Changing the vertical size from a relative to an absolute scale is good and it works with the longstrings and in particular if "g" is in the label.

This revision is now accepted and ready to land.Feb 28 2017, 12:51 PM

Closed by commit rP19251: Some small replaymenu gui fixes (authored by Imarok). · Explain WhyFeb 28 2017, 6:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

replaymenu/

replay_menu.xml

14 lines

Diff 647

View Options

ps/trunk/binaries/data/mods/public/gui/replaymenu/replay_menu.xml

Some small replaymenu gui fixesClosedPublicActions