Differential D865
Cleanup damage type related code in cmpDamageReceiver and cmpDamage. Authored by • leper on Sep 3 2017, 2:41 AM.
Details
Should make it easy to change the schema to something along the lines of <oneOrMore> with somewhat arbitrary names. Would need a slight change to GetArmourStrengths to make that actually parse anything. TODO: Is it the right choice to not deal any damage if that damage type isn't present in the armour? Check that this doesn't break anything
Diff Detail
Event TimelineComment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files... http://jenkins-master:8080/job/phabricator/1955/ for more details. Comment Actions Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl... http://jenkins-master:8080/job/phabricator_lint/472/ for more details. Comment Actions changes seem sane also with the changes i planned on #252 in the back of my mind. wrt TODO, we could also see it as a feature to not deal any damage, like we hack for siege engines, perhaps only this would be better done with an infinity tag or so. If we consider doing that (in another rev) mods should specify everything and a warning would be in place. some style issues though:
Comment Actions The main issue with that ticket (and others that are as old would be that they are very limiting. Going from 1 attack to 2 attacks is strange if we could just go from 1 to multiple.
Having thought about this a little more, it makes more sense to deal full damage in case there is no armor for a certain type of damage. Opinions?
Comment Actions See my github for n attack types :P
maybe just warn? Comment Actions
Assuming you mean the lower case branch instead of that one, that seems somewhat nicer than previous iterations I have seen.
Would be a possibility, but that would prevent mods from adding a few units with a new damage type (eg radiation) and corresponding armour (lead) that are good against units already present, but that do not have those types currently. (Note that I think we should make the damage types optional (requiring at least one?) in most places so extending those is easier without breaking everything. Might make validation harder though.) Comment Actions Deal full damage in case there is no armour for a given damage type. Remove invalid part of a comment "(between 0 and 1)". Comment Actions Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl... http://jenkins-master:8080/job/phabricator_lint/485/ for more details. Comment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files... http://jenkins-master:8080/job/phabricator/1970/ for more details. Comment Actions Meh that cap,
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||