Page MenuHomeWildfire Games

Make FromJSProperty actually part of ScriptInterface.
ClosedPublic

Authored by leper on Sep 6 2017, 6:20 AM.

Details

Reviewers
vladislavbelov
Imarok
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Owners Package(Owns No Changed Paths)
Commits
rP20179: Make FromJSProperty actually part of ScriptInterface.
Summary

Mostly so this can be nicely used as scriptInterface.FromJSProperty(...).

Test Plan

Check that it still compiles, the change makes things only clearer and that's it.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

leper created this revision.Sep 6 2017, 6:20 AM
Vulcan added a subscriber: Vulcan.Sep 6 2017, 7:07 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jenkins-master:8080/job/phabricator/1980/ for more details.

Vulcan added a comment.Sep 6 2017, 7:09 AM
Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jenkins-master:8080/job/phabricator_lint/495/ for more details.

Imarok accepted this revision.Sep 7 2017, 12:45 AM
Imarok added a subscriber: Imarok.

compiles and is complete

This revision is now accepted and ready to land.Sep 7 2017, 12:45 AM
This revision was automatically updated to reflect the committed changes.