Add biome strings.
Details
Details
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jenkins-master:8080/job/phabricator/1991/ for more details.
Comment Actions
Thanks for the update! The biomes were separated to new JSON files, so that we can add or remove biomes arbitrarily. These strings should be moved there too. I will look into it and merge then.
(Also the biome should be seen in the map description of the gamesetup and objectives dialog. soon).
| binaries/data/mods/public/simulation/data/settings/biomes.json | ||
|---|---|---|
| 2 ↗ | (On Diff #3561) | (Title, Description) |
Comment Actions
I have found some additional trivia about the biomes in rP20129:
Savanna // Using the Malawi as a reference, in parts where it's not too murky from a river nearby. Tropic // Bora-Bora ish. Quite transparent, not wavy. // Mostly for shallow maps. Maps where the water level goes deeper should use a much darker Water Color to simulate deep water holes. Autumn // basically temperate with a reddish twist in the reflection and the tint. Also less wavy. // this assumes ocean settings, maps that aren't oceans should reset.
(The other ones were useless)
Temperate // temperate ocean blue, a bit too deep and saturated perhaps but it looks nicer. // this assumes ocean settings, maps that aren't oceans should reset. Snowy // Water is a semi-deep blue, fairly wavy, fairly murky for an ocean. // this assumes ocean settings, maps that aren't oceans should reset. Desert // Went for a very clear, slightly blue-ish water in this case, basically no waves. Alpine // simulates an alpine lake, fairly deep. // this is not intended for a clear running river, or even an ocean. Mediterranean // Guess what, this is based on the colors of the mediterranean sea.
Comment Actions
The strings are very compelling, well thought, using a broad vocabulary and informing the players what they can expect from the biome.
The biome definitions are caught completely in the descriptions.
Great work, thanks!
| binaries/data/mods/public/simulation/data/settings/biomes.json | ||
|---|---|---|
| 18 ↗ | (On Diff #3561) | Thats a great one |
| 23 ↗ | (On Diff #3561) | the surrounding part is odd, leaving it out |
| 33 ↗ | (On Diff #3561) | that and should be an or |
| 38 ↗ | (On Diff #3561) | parentheses -> commas |
| 43 ↗ | (On Diff #3561) | Great alternative introduction, love it! |