Fix build on FreeBSD head
ClosedPublic
Actions

Authored by madpilot on Sep 8 2017, 10:26 AM.

Details

Reviewers

Itms
• leper

Commits

rP20180: Fix SpiderMonkey build on FreeBSD 12. Fixes #4765.

Summary

In FreeBSD base system revision 315662 hid the struct inpcb and struct tcpcb from userland.

struct xinpcb and struct xtcpcb should be used in their place, which contain only userland parts. No kernel space references.

The version of psutil embedded in 0ad needs paatching to compile on recent FreeBSD versions.

Attached patch is base on the one in the psutil 1.2.1 port present in the FreeBSD ports tree which has the same problem.

Test Plan

Compiled software through the FreeBSD ports system and ran it.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

madpilot created this revision.Sep 8 2017, 10:26 AM

Thanks for informing us, providing all the details and the patch!
Since I can't tell when we'll get to this patch, I have created a ticket #4765, so that we don't release without considering this patch.

Also we add an entry to programming.json for the first patch someone commits. So if you want a different nickname to be present there or your realname in addition, let us know.

Hi,

madpilot is ok for the nickname and if it causes no problems I'd like my real name (Guido Falsi) attached in additon.

Thanks.

@madpilot You have to add it yourself when providing a diff :)

@Stan I did not understand, sorry. Going to update the patch soon.

Added myself to programming.json.

Might be nice to open a bug report upstream, though as https://bugzilla.mozilla.org/show_bug.cgi?id=1238983 does already exist that might not change a lot.

This revision is now accepted and ready to land.Sep 13 2017, 1:50 AM

Closed by commit rP20180: Fix SpiderMonkey build on FreeBSD 12. Fixes #4765. (authored by • leper). · Explain WhySep 13 2017, 2:10 AM

This revision was automatically updated to reflect the committed changes.