Page MenuHomeWildfire Games

Regrouped special technologies
Needs ReviewPublic

Authored by Nescio on Sep 8 2017, 12:41 PM.

Details

Reviewers
wraitii
Summary

D1472/rP22083 grouped all civbonus technologies in a single civbonuses/ folder.
D1775/rP23770 deleted unused technologies that were deprecated years ago.

Special technologies are technologies that have a "civ": or "notciv": requirement, i.e. they're available to one or more factions, but not all. Currently some are grouped alongside regular technologies, others are arbitrarily distibuted over the carthaginians/, hellenes/, kushites/, persians/, romans/, and successors/ subdirectories.
This patch:

  • moves special technologies out of those subdirectories, occassionally implementing more consistent naming;
  • updates templates accordingly;
  • set 'svn:mime-type' and 'svn:eol-style' for all technologies (*.json was much faster than typing the moved file names one by one).
Test Plan

Check for mistakes and omissions, verify everything still works.

Event Timeline

Nescio created this revision.Sep 8 2017, 12:41 PM
Owners added a subscriber: Restricted Owners Package.Sep 8 2017, 12:41 PM
Nescio updated this revision to Diff 3579.Sep 8 2017, 4:24 PM
Nescio retitled this revision from Grouped all civbonuses under /technologies/civbonuses/ to Regrouped civbonuses and special technologies.
Nescio edited the summary of this revision. (Show Details)
Nescio edited the test plan for this revision. (Show Details)
Nescio added a reviewer: fatherbushido.

Regrouped all civbonuses under /technologies/civbonuses/ *and* all special technologies under /technologies/special/

Reason: I was informed it was more important that diffs are complete than that they're small.

Nescio edited the summary of this revision. (Show Details)Sep 8 2017, 4:25 PM
Nescio added a reviewer: bb.Sep 8 2017, 11:42 PM
fatherbushido resigned from this revision.EditedSep 9 2017, 6:58 AM

I have a lot of respect for your work. I'd say also that your mod really shows your ability to manage such things (even if I am basically not fond of those hard bonuses). So, if I was the guy who gives congratulations, I'd congratulate you.
I also share your observation/analysis.
For information there were such a suggestion: (staff only) https://wildfiregames.com/forum/index.php?/topic/21563-subfolders-in-simulationdatatechnologies/
But I won't review your diff, sorry.

Nescio updated this revision to Diff 3603.Sep 9 2017, 8:50 AM
Nescio edited the summary of this revision. (Show Details)

Minor correction

Vulcan added a subscriber: Vulcan.Sep 9 2017, 9:37 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jenkins-master:8080/job/phabricator/2002/ for more details.

Nescio edited the summary of this revision. (Show Details)Sep 9 2017, 1:19 PM
Nescio updated this revision to Diff 7485.Feb 16 2019, 10:29 AM
Nescio edited the summary of this revision. (Show Details)
Nescio edited the test plan for this revision. (Show Details)
Nescio removed reviewers: fatherbushido, bb.
Nescio edited the summary of this revision. (Show Details)
Nescio edited the test plan for this revision. (Show Details)
Nescio added subscribers: Stan, fatherbushido.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/1057/

Nescio edited the summary of this revision. (Show Details)Feb 16 2019, 10:31 AM
Nescio retitled this revision from Regrouped civbonuses and special technologies to Regrouped special technologies.Feb 16 2019, 10:35 AM

@Nescio think this needs a rebase

Nescio planned changes to this revision.Jul 28 2020, 10:45 AM

Yes, it does. (I believe D918 is up to date, though.)

Nescio updated this revision to Diff 12965.Jul 30 2020, 8:09 PM
Nescio edited the summary of this revision. (Show Details)
Nescio edited the test plan for this revision. (Show Details)

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2807/display/redirect

Nescio updated this revision to Diff 12966.Jul 30 2020, 8:19 PM
  • forgot athen marines

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2808/display/redirect