Add id for IQ stanzas
ClosedPublic
Actions

Authored by Dunedan on Sep 10 2017, 5:38 PM.

Details

Reviewers

elexis
Imarok

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP20321: Add id for IQ stanzas

Summary

XMPP mandates that IQ stanzas contain an id attribute ("The 'id' attribute is REQUIRED for IQ stanzas.").
Up to now 0ad didn't set one causing it to fail to work properly with recent ejabberd versions, which respond with "bad request" to IQ stanzas without id. This patch fixes that issue.

Test Plan

Just check the commands send to ejabberd without and with the patch. Without the <iq/> element doesn't include an id, with it does.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Dunedan created this revision.Sep 10 2017, 5:38 PM

Stan added reviewers: Restricted Owners Package, elexis.Sep 12 2017, 2:17 PM

elexis awarded a token.Sep 12 2017, 3:15 PM

Imarok added a reviewer: Imarok.Oct 1 2017, 7:07 PM

As said in irc already, it should probably be checked before why we don't get back the correct id when sending iqs to the bot.

In D899#37194, @Imarok wrote:

As said in irc already, it should probably be checked before why we don't get back the correct id when sending iqs to the bot.

That's simply because XpartaMuPP doesn't implement the necessary logic (yet) to return the original id in the responses. Doesn't matter for this patch though, as it's a different issue and works fine without.

In D899#37199, @Dunedan wrote:

In D899#37194, @Imarok wrote:

As said in irc already, it should probably be checked before why we don't get back the correct id when sending iqs to the bot.

That's simply because XpartaMuPP doesn't implement the necessary logic (yet) to return the original id in the responses. Doesn't matter for this patch though, as it's a different issue and works fine without.

Ok, then wanna make a ticket about that?

In D899#37200, @Imarok wrote:

Ok, then wanna make a ticket about that?

Here you go: https://trac.wildfiregames.com/ticket/4812

In D899#37216, @Dunedan wrote:

In D899#37200, @Imarok wrote:

Ok, then wanna make a ticket about that?

Here you go: https://trac.wildfiregames.com/ticket/4812