Page MenuHomeWildfire Games
Differential D911

[gui] brighter pure white text font colour in “mod selection” screen
ClosedPublic
Actions

Authored by Nescio on Sep 16 2017, 9:37 AM.

Details

Reviewers
• leper
Commits
rP20195: Use white text in the mod selection screen. Patch by Nescio.
Summary

Formerly some of the text font colours used under “Tools & Options”, “Mod Selection” were quite hard to read, especially the dark green and dark grey on the dark grey background. This patch changes all of them to pure white.

Note: the colours defined in lines 103 and 150 of the modmod.xml file are irrelevant; although most colours are defined in this file, the “(folder)” colour is actually defined in line 185 of the modmod.js file; nevertheless, I've changed all three lines to white 255 255 255) to make sure the colours match.

Test Plan

Tiny patch

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.EditedSep 16 2017, 9:37 AM

Before:


First suggestion:

New proposal:

Lion's suggestion:

Everything white:

Vulcan added a subscriber: Vulcan.Sep 16 2017, 10:25 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jenkins-master:8080/job/phabricator/2034/ for more details.

Harbormaster completed remote builds in B3181: Diff 3680.Sep 16 2017, 10:25 AM
Lionkanzen added a subscriber: Lionkanzen.Sep 16 2017, 2:41 PM

Change blue with cyan, that blue don't makes enogh contrast.
Try use same scheme from the game or websites.

vladislavbelov added a subscriber: vladislavbelov.Sep 16 2017, 2:45 PM
In D911#35506, @Nescio wrote:

After:

It looks like a rainbow, I think it needs a palette, more nice color scheme. As @Lionkanzen said, the game/forum palette can be used.

Nescio added a comment.Sep 16 2017, 2:53 PM
In D911#35525, @vladislavbelov wrote:

It looks like a rainbow, I think it needs a palette, more nice color scheme. As @Lionkanzen said, the game/forum palette can be used.

Yeah, it does, because those rainbow colours are bright :) Anyway, where can I find the game and forum palettes?

Lionkanzen added a comment.Sep 16 2017, 4:21 PM

I can search color schemes, rainbow are over saturated color contrast is based in the opposite of a color.
If your have dark color you must use light colors no necessary over saturated as you are using here.
You can use light gray almost white, a lighter red but not so saturated. Same with yellow or use some color like this.

https://i.imgur.com/b9FcEgl.jpg

Nescio added a comment.EditedSep 16 2017, 5:43 PM

Yes, I'm aware there are hundreds (or actually 256^3=16777216) of possible shades I could use. However, I'm not a graphical artist, and if I have to choose contrast-rich colours, I typically pick the easiest :) Besides, the primary purpose of this patch is to improve the visibility of the text; making it pleasing to the eye is secondary; the mod selection screen is often closed within a minute or two, so it's not that important.

If there is a certain colour palette or style used in the game or forums, please post where I can look up the colour values.

Anyway, how about these softer (lighter, fainter) colours?

Yes, it's still rainbow-ish; I could also change all text to pure white, but that would be a bit boring, I guess.

Lionkanzen added a comment.Sep 16 2017, 5:45 PM

Yes, and I'm the graphical artist.

Nescio added a comment.Sep 16 2017, 5:47 PM

Any specific RGB values you'd like to see me implement?

Nescio updated this revision to Diff 3685.Sep 16 2017, 5:55 PM

Implemented softer colours (still “rainbow”-ish).

Lionkanzen added a comment.Sep 16 2017, 6:28 PM

img=https://k60.kn3.net/1/6/6/7/3/5/93D.png
check this.

the first is white.
RGB
second is 224 106 75
next; 232 197 139
4 next: 211 209 207
5 next: 224 106 75
6 next: 247 210 57
7: 218 215 197

Nescio added a comment.Sep 16 2017, 6:44 PM

Thanks for the suggestion. When I apply those values I get:

Personally I think those colours are too similar (and I don't understand why you want 2 and 5 to be completely identical) and I actually prefer the current diff colours instead.

Lionkanzen added a comment.Sep 16 2017, 8:05 PM

Yes, that proposed all look like single thing.

Vulcan added a comment.Sep 16 2017, 9:14 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jenkins-master:8080/job/phabricator/2037/ for more details.

Harbormaster completed remote builds in B3187: Diff 3685.Sep 16 2017, 9:14 PM
• leper added a subscriber: • leper.Sep 17 2017, 5:10 AM

I'd actually prefer something with more plain white text, and possibly colour-coded (red/green) for (in)compatible versions. Since the dependency colouring would need some code I guess not changing that would be an improvement too.

Nescio added a comment.Sep 17 2017, 11:28 AM

Updated the first post to show how displaying all columns in white would look. Personally I think using different (rainbow) colours is a bit clearer, but I have no objections to changing all text to an uniform white.

• leper added a comment.Sep 17 2017, 10:02 PM
In D911#35632, @Nescio wrote:

Updated the first post to show how displaying all columns in white would look. Personally I think using different (rainbow) colours is a bit clearer, but I have no objections to changing all text to an uniform white.

Having those rainbow colours reminds me more of children's toys than making me actually want to read the content.

If you prefer different colours, maybe have two and alternate them for the individual columns. (Something similar with background colours and rows might also be nice, but since we do have a different background when selecting that doesn't seem very important.)

If you want more than one colour I'll wait for another proposal, else I might commit the white one.

Nescio updated this revision to Diff 3701.Sep 17 2017, 11:05 PM
Nescio retitled this revision from brighter text font colours in “mod selection” screen to brighter pure white text font colour in “mod selection” screen.
Nescio edited the summary of this revision. (Show Details)

pure white

Nescio added a comment.Sep 17 2017, 11:06 PM

The purpose of this patch is to improve the visibility of the text. White is perfectly suitable for that, and I agree it's probably the best option. Feel free to commit.

Vulcan added a comment.Sep 17 2017, 11:51 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jenkins-master:8080/job/phabricator/2045/ for more details.

Harbormaster completed remote builds in B3198: Diff 3701.Sep 17 2017, 11:51 PM
ffffffff added a subscriber: ffffffff.Sep 18 2017, 1:45 AM
In D911#35666, @leper wrote:
In D911#35632, @Nescio wrote:

Updated the first post to show how displaying all columns in white would look. Personally I think using different (rainbow) colours is a bit clearer, but I have no objections to changing all text to an uniform white.

Having those rainbow colours reminds me more of children's toys than making me actually want to read the content.

If you prefer different colours, maybe have two and alternate them for the individual columns. (Something similar with background colours and rows might also be nice, but since we do have a different background when selecting that doesn't seem very important.)

If you want more than one colour I'll wait for another proposal, else I might commit the white one.

+1

• leper accepted this revision.Sep 18 2017, 5:06 AM

Quite bright, but I guess having it usable is more important.

I guess someone could do some improvement to the whole thing (and possibly making it somewhat uniform with other tables like the replay menu one.

This revision is now accepted and ready to land.Sep 18 2017, 5:06 AM
Closed by commit rP20195: Use white text in the mod selection screen. Patch by Nescio. (authored by • leper). · Explain WhySep 18 2017, 5:09 AM
This revision was automatically updated to reflect the committed changes.
elexis mentioned this in rP20552: Cleanup mod selection GUI page..Nov 28 2017, 11:43 PM
Nescio retitled this revision from brighter pure white text font colour in “mod selection” screen to [gui] brighter pure white text font colour in “mod selection” screen.May 18 2020, 10:35 AM

Revision Contents
Changeset List

PathSize
ps/
trunk/
binaries/
data/
mods/
mod/
gui/
modmod/
8 lines
28 lines

Diff 3703

View Options

ps/trunk/binaries/data/mods/mod/gui/modmod/modmod.js

Loading...
View Options

ps/trunk/binaries/data/mods/mod/gui/modmod/modmod.xml

Loading...
Wildfire Games · Phabricator