Remove a brit fortress bonus
ClosedPublic
Actions

Authored by fatherbushido on Sep 16 2017, 9:22 PM.

Details

Reviewers: None
Commits: rP20192: Remove a Brit fortress bonus. Agreed by scythetwirler.

Summary

Doesn't seem really needed for the moment. Nuking that will allow easier maintenance and those kind of things could be added later in the dev.

Test Plan

Nothing really to test.
Was ack here https://code.wildfiregames.com/D76#inline-1291

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

fatherbushido created this revision.Sep 16 2017, 9:22 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jenkins-master:8080/job/phabricator/2038/ for more details.

Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jenkins-master:8080/job/phabricator_lint/527/ for more details.

Harbormaster completed remote builds in B3188: Diff 3686.Sep 16 2017, 10:11 PM

Closed by commit rP20192: Remove a Brit fortress bonus. Agreed by scythetwirler. (authored by fatherbushido). · Explain WhySep 17 2017, 7:22 AM

This revision was automatically updated to reflect the committed changes.

Indeed a leftover:

rP9994 range buff to 80m for all forts
rP11952 brit introduced with 80m
rP14179 increased to 85m to attack siege engines
rP16377 85m to 72m for all forts except brit

elexis mentioned this in rP20192: Remove a Brit fortress bonus. Agreed by scythetwirler..Sep 17 2017, 10:21 AM

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

templates/

structures/

brit_fortress.xml

9 lines

Diff 3687

View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/brit_fortress.xml

Remove a brit fortress bonusClosedPublicActions