Differential D916

Rename cmpPosition's IsFloating to CanFloat.
ClosedPublic
Actions

Authored by • leper on Sep 18 2017, 11:19 AM.

Details

Reviewers

fatherbushido

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP20201: Rename cmpPosition's IsFloating to CanFloat.

Summary

There might appear a function that would fit the IsFloating or IsCurrentlyFloating
moniker better than this one, so rename it now to avoid confusion.

I lean towards naming that new function IsCurrentlyFloating, to avoid confusion (and possibly break people who have been using that function instead of silently changing behaviour).

Test Plan

Compile it. Possibly complain about the naming of m_Floating.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

• leper created this revision.Sep 18 2017, 11:19 AM

I am fine with keeping m_Floating name (not as confusing as the function name)

I found the same occurences in the whole repo.
Compilation ok, test ok.

This revision is now accepted and ready to land.Sep 18 2017, 11:41 AM

Closed by commit rP20201: Rename cmpPosition's IsFloating to CanFloat. (authored by • leper). · Explain WhySep 18 2017, 11:55 AM

This revision was automatically updated to reflect the committed changes.

Build has FAILED

Link to build: http://jenkins-master:8080/job/phabricator/2049/
See console output for more information: http://jenkins-master:8080/job/phabricator/2049/console

Harbormaster failed remote builds in B3207: Diff 3709!Sep 18 2017, 12:01 PM

Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jenkins-master:8080/job/phabricator_lint/534/ for more details.