Page MenuHomeWildfire Games

Remove wrong refs in template_ templates
ClosedPublic

Authored by fatherbushido on Sep 21 2017, 7:47 PM.

Details

Summary

(Only) two wrong refs.
We could keep them but...

Test Plan

If that would break something, it would already be broken

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

fatherbushido created this revision.Sep 21 2017, 7:47 PM

(By the way, I wonder if the template_structure_special template has still reason to exist (some times ago, there were those special buildings sb1, sb2. But now, we have really different things inheriting from that.)

binaries/data/mods/public/simulation/templates/template_rubble.xml
28 ↗(On Diff #3737)

We could also remove it, letting something generic is ok too.
No pref from my side, I will follow reviewer.

binaries/data/mods/public/simulation/templates/template_structure_special.xml
45 ↗(On Diff #3737)

(we could also let a place holder, I found nothing)

Vulcan added a subscriber: Vulcan.Sep 21 2017, 8:35 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jenkins-master:8080/job/phabricator/2057/ for more details.

Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jenkins-master:8080/job/phabricator_lint/539/ for more details.

This revision was automatically updated to reflect the committed changes.