Page MenuHomeWildfire Games

List command for lobby having quick view of all users
Needs ReviewPublic

Authored by ffffffff on Sep 23 2017, 7:36 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

..instead of scrolling playerlist

equal to gamesetup users list

sorted alphabeticly

and player names colored

on commit replace

g_TestPlayerList

with

Engine.GetPlayerList()

Test Plan

test

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

ffffffff created this revision.Sep 23 2017, 7:36 PM
ffffffff updated this revision to Diff 3764.Sep 23 2017, 7:42 PM

Missing semicolon.

vladislavbelov added inline comments.
binaries/data/mods/public/gui/lobby/lobby.js
315

I think, it needs to be before kick, as commands should be grouped by using.

320

It looks strange for me, because IMO messages need to be from system. We shouldn't use from as formatter.

elexis removed a reviewer: elexis.Oct 22 2017, 7:14 PM

Readers of the diff might also miss two translates.

In D928#37993, @elexis wrote:

Readers of the diff might also miss two translates.

Why two? I think 1 or 3.

In D928#37993, @elexis wrote:

Readers of the diff might also miss two translates.

Why two? I think 1 or 3.

Assuming these strings, there should be three translate calls but it misses two.

ffffffff updated this revision to Diff 4584.Dec 6 2017, 12:20 AM
ffffffff edited the summary of this revision. (Show Details)
ffffffff updated this revision to Diff 4586.Dec 6 2017, 12:27 AM

translate

ffffffff edited the summary of this revision. (Show Details)Dec 6 2017, 12:38 AM
ffffffff updated this revision to Diff 4597.Dec 6 2017, 12:23 PM

killed warn

bb added subscribers: Vulcan, bb.Jan 12 2018, 9:35 PM

Comparing the order in on the left site reveals that we use another order regarding moderators, maybe nice to keep that order consistent (one could look into merging the logic)

Were thinking about merging this with he ingame /list command, but considered out of scope

binaries/data/mods/public/gui/lobby/lobby.js
330

"List all users in the lobby."

335–336

shouldn't do a newline here

338

maybe translation comment

340

missing space

340–342

return statements on a new line, but a ternary could work too

341

no need for +

ffffffff updated this revision to Diff 5264.Jan 13 2018, 1:36 AM
ffffffff edited the summary of this revision. (Show Details)
ffffffff updated this revision to Diff 5428.Jan 22 2018, 8:03 PM

g_LocaleCompare and unified translate phrase.