Page MenuHomeWildfire Games
Differential D948

Players/Games Numbers Stats in Lobby
Needs RevisionPublic
Actions

Authored by ffffffff on Oct 6 2017, 12:57 AM.

Details

Reviewers
elexis
Imarok
JoshuaJB
bb
Summary

Showing numbers of players and games in a text label above players list. (with online players and open games as green numbers.)

In tooltip show buddies and buddy games numbers (again onlines and open games as green numbers.)

current implementation:

with tooltip

old ideas:

Center label:

or as input readonly

Test Plan

Test the conditions array for multiple/single players/games/buddies/onlines.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

ffffffff created this revision.Oct 6 2017, 12:57 AM
ffffffff updated this revision to Diff 3845.Oct 6 2017, 1:00 AM

Smalle corrections.

ffffffff updated this revision to Diff 3846.Oct 6 2017, 1:38 AM

Center label.

ffffffff edited the summary of this revision. (Show Details)Oct 6 2017, 1:39 AM
ffffffff edited the summary of this revision. (Show Details)
ffffffff edited the summary of this revision. (Show Details)Oct 7 2017, 9:05 PM
ffffffff added a comment.Nov 17 2017, 6:32 AM

little different https://imgur.com/a/CuBfX

show online player / open games

Polakrity added a subscriber: Polakrity.Nov 17 2017, 11:27 AM

The number of games can be split above the GamePanel imo.

ffffffff updated this revision to Diff 4317.Nov 22 2017, 1:10 AM

Updated version showing also in green available players/open games to for looking if enough player available for a new game or for knowing there is a open game to enter.

ffffffff added a comment.Nov 22 2017, 1:11 AM
In D948#41156, @Polakrity wrote:

The number of games can be split above the GamePanel imo.

Yes we thought about this but then u need either a new line which cost space from gamepanel or chat or nuking some filter, what we dont wanted.

ffffffff mentioned this in D293: Proposal for games header in Lobby.EditedNov 25 2017, 2:54 PM
In D948#41655, @ffffffff wrote:

Updated version showing also in green available players/open games to for looking if enough player available for a new game or for knowing there is a open game to enter.

this seems pretty final for me now. any other proposals?

please discuss

(i delete D293 as its merged now in this.)

ffffffff edited the summary of this revision. (Show Details)Nov 25 2017, 2:56 PM
ffffffff added subscribers: Hannibal_Barca, bb, temple, Imarok.
ffffffff edited the summary of this revision. (Show Details)Nov 25 2017, 2:58 PM
ffffffff added a comment.Dec 1 2017, 10:47 AM

@elexis how about that: "Auto spreading games players numbers header over different window sizes and hidden numbers into tooltip." https://imgur.com/a/fq2hM

ffffffff updated this revision to Diff 5474.Jan 24 2018, 7:25 PM

design

ffffffff updated this revision to Diff 5477.EditedJan 24 2018, 7:38 PM

rebase to r21003 and redesign easy to read


ffffffff added inline comments.Jan 24 2018, 7:41 PM
binaries/data/mods/public/gui/lobby/lobby.js
104

All players in the lobby.

989

updatePlayerGamesNumberInfo maybe

1042

maybe new line

ffffffff added a reviewer: Imarok.Jan 24 2018, 7:41 PM
ffffffff removed a subscriber: Imarok.
ffffffff added a reviewer: JoshuaJB.Jan 24 2018, 9:47 PM
ffffffff edited the summary of this revision. (Show Details)Jan 24 2018, 11:25 PM
elexis awarded a token.Jan 24 2018, 11:27 PM
ffffffff updated this revision to Diff 5493.Jan 25 2018, 9:04 PM

bugfix text width string number info.

ffffffff added a subscriber: mapkoc.Jan 27 2018, 12:31 AM
ffffffff added inline comments.Jan 30 2018, 10:13 AM
binaries/data/mods/public/gui/lobby/lobby.js
1000

setstringtags

1051

setstringtags

ffffffff added inline comments.Feb 19 2018, 10:43 PM
binaries/data/mods/public/gui/lobby/lobby.js
1038

[position, buddyInfo] ,...

ffffffff mentioned this in D893: Hiding profile panel in lobby when it is not required for having a longer playerlist.Feb 27 2018, 12:37 AM
bb requested changes to this revision.Apr 6 2018, 6:12 PM

for a24

binaries/data/mods/public/gui/lobby/lobby.js
991

let playerGamesNumber = ...

992

info can mean anything, make more specific

995

maybe nice to also show the busy/unavailable count?

998

don't see the need to making this array and destroying it a few lines below, just make the string at ones

999–1000

probably inline too (with ternary)

1001

s/info/name

1002

not sure about the used order, wouldn't it be more logical to state available/total?

1007–1033

maybe have some sort of loop to undupe this even further

1042–1048

don't like the "not showing when not enough space",maybe just let it use newlines? (so adapt the size of the object below)

1051

there is a tooltip_font tag afaik

binaries/data/mods/public/gui/lobby/lobby_panels.xml
17

could be split, meh whatever

24

(maybe for 1 line text stop the autistic screeching by using 25, so aligning with middle panel)

This revision now requires changes to proceed.Apr 6 2018, 6:12 PM
bb mentioned this in D285: Lobby player search input.Sep 6 2021, 10:02 AM

Revision Contents
Changeset List

PathSize
binaries/
data/
mods/
public/
gui/
lobby/
76 lines
7 lines

Diff 5493

View Options

binaries/data/mods/public/gui/lobby/lobby.js

Loading...
View Options

binaries/data/mods/public/gui/lobby/lobby_panels.xml

Loading...
Wildfire Games · Phabricator