Page MenuHomeWildfire Games

Let some heros upgrade to mount or unmount.
AbandonedPublic

Authored by fatherbushido on Oct 13 2017, 6:27 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

Follow the idea of rP19095 which was reverted in rP19103 (it was not working).
The bugs are now (I hope) fixed.
So basically I could just commit again that reverted part. But while at it, ...

Sure the chariot come from nowhere, ...
It's not something which is my deep desire, so add a request and I will adress it. (Even a "no" is ok). But don't start eternal discussion.

It's mainly a diff to test bugs of the upgrade feature and see how that feature work in game.

(I don't adress file namming in that diff).

Needs D960.

Test Plan

-

Event Timeline

fatherbushido added inline comments.Oct 13 2017, 6:31 PM
binaries/data/mods/public/simulation/templates/units/brit_hero_boudicca.xml
22

5 time is the upper limit imo.
cost?
Same for the others.

binaries/data/mods/public/simulation/templates/units/brit_hero_cunobelin.xml
11

string?

binaries/data/mods/public/simulation/templates/units/brit_hero_cunobelin_infantry.xml
15

(5)

binaries/data/mods/public/simulation/templates/units/pers_hero_xerxes.xml
4

I forgot to remove it. Is this a good idea? Suggestion?

fatherbushido marked 2 inline comments as done.Oct 13 2017, 6:51 PM
Vulcan added a subscriber: Vulcan.Oct 13 2017, 7:12 PM

Build is green

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jenkins-master:8080/job/phabricator/2120/ for more details.

Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...

http://jenkins-master:8080/job/phabricator_lint/591/ for more details.

Build is green

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jenkins-master:8080/job/phabricator/2121/ for more details.

Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...

http://jenkins-master:8080/job/phabricator_lint/592/ for more details.

fatherbushido edited the summary of this revision. (Show Details)Oct 29 2017, 10:26 AM

I'm not requesting changes - so you can commit it if you wish - but don't do this. I created https://code.wildfiregames.com/D281 explicitly for this kind of stuff.

In D961#38795, @wraitii wrote:

I'm not requesting changes - so you can commit it if you wish - but don't do this. I created https://code.wildfiregames.com/D281 explicitly for this kind of stuff.

ok
-> pm

fatherbushido abandoned this revision.Nov 1 2017, 3:37 PM