Differential D963

No need to create aura's rangequery when the aura is not applied
ClosedPublic
Actions

Authored by mimo on Oct 15 2017, 12:09 PM.

Details

Reviewers

fatherbushido

Commits

rP20300: No need to create aura's rangequery when the aura is not applied

Summary

as the title say

Test Plan

check that everything works as expected

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mimo created this revision.Oct 15 2017, 12:09 PM

Build has FAILED

Link to build: http://jenkins-master:8080/job/phabricator/2126/
See console output for more information: http://jenkins-master:8080/job/phabricator/2126/console

Harbormaster failed remote builds in B3396: Diff 3893!Oct 15 2017, 12:27 PM

Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...

http://jenkins-master:8080/job/phabricator_lint/597/ for more details.

Indeed, it's bad to initiate those queries and to not use them.
Tested with female inspiration tech. Nothing wrong.
Looking at the code, I don't expect any wrong thing. (I tried to imagine some weird cases).

Nice to improve the performance of something not yet used ;-)

binaries/data/mods/public/simulation/components/Auras.js
228 ↗	(On Diff #3893)	(Unrelated, but It seems we can remove that comment :))

This revision is now accepted and ready to land.Oct 15 2017, 2:02 PM

Closed by commit rP20300: No need to create aura's rangequery when the aura is not applied (authored by mimo). · Explain WhyOct 15 2017, 5:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

components/

Auras.js

22 lines

RangeVisualization.js

4 lines

Diff 3894

View Options

ps/trunk/binaries/data/mods/public/simulation/components/Auras.js