Page MenuHomeWildfire Games

Don't show silhouettes through fields and berries
Needs RevisionPublic

Authored by temple on Oct 21 2017, 3:04 AM.

Details

Reviewers
wraitii
Trac Tickets
#4829
Summary

We use silhouettes for units hiding behind trees and buildings. We can walk over fields and berries instead of hiding behind them, so the silhouettes are more distracting than helpful.

This patch changes the field and berries to be like the grass actors on The Nile, for example:

Test Plan

Agree with the change.

(Berry bushes still need to be cleaned up in D845.)

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

temple created this revision.Oct 21 2017, 3:04 AM
temple updated this revision to Diff 3907.Oct 21 2017, 3:08 AM
elexis added a subscriber: elexis.Oct 21 2017, 3:55 AM
elexis added inline comments.
binaries/data/mods/public/simulation/templates/template_gaia_flora_bush.xml
18 ↗(On Diff #3907)

Ah that's good, had bothered me too. Should apple trees be affected too by this change?

temple added inline comments.Oct 21 2017, 6:01 PM
binaries/data/mods/public/simulation/templates/template_gaia_flora_bush.xml
18 ↗(On Diff #3907)

They can hide our whole body rather than just our feet, so they should probably be treated like other trees (and obstruct movement too). I've updated D845.

temple updated this revision to Diff 3984.Oct 26 2017, 9:37 PM

Use berry template instead of bush, since we now have wood bushes (that can't be walked over so should still show silhouettes).

bb added a subscriber: bb.Nov 25 2017, 10:50 PM

butbutbut fields and bushes can hide whole chicken f.e. so in combination with D965 this would kinda break

In D966#42306, @bb wrote:

butbutbut fields and bushes can hide whole chicken f.e. so in combination with D965 this would kinda break

That's a good point, so I would prefer a more proper fix to #4829.

On the other hand, in a22 fields and bushes can hide whole chickens, so we're not making anything worse.

bb added a comment.Nov 25 2017, 11:24 PM

I wonder if it would be nice to use the footprint.height tag for this, as in when the height of the occluder is heigher than the occluded => show the silhouette when the occluded template wants that, otherwise let it depend also on the occluder visualactor stuff.

wraitii requested changes to this revision.Dec 3 2017, 6:42 PM
wraitii added a subscriber: wraitii.

I think this is the wrong way to go about it.

Instead we should render silhouette casters as anti-occluders using the depth map, so that a silhouette is never renderer on top of the actual visible model, which just looks weird.

This revision now requires changes to proceed.Dec 3 2017, 6:42 PM
In D966#43795, @wraitii wrote:

I think this is the wrong way to go about it.

Instead we should render silhouette casters as anti-occluders using the depth map, so that a silhouette is never renderer on top of the actual visible model, which just looks weird.

It'll be up to someone else to try that because I don't have much of an idea about what's going on.

for a quick fix this seems easily fine.
Especially until other fix comes...