Page MenuHomeWildfire Games

Fix typo in log message
ClosedPublic

Authored by LudovicRousseau on Oct 22 2017, 7:00 PM.

Details

Summary

Debian lintian tool reported a spelling error

I: 0ad: spelling-error-in-binary usr/games/pyrogenesis defintions definitions

Test Plan

"defintions" is not correct.
"definitions" is the correct spelling.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bb added a reviewer: bb.Oct 22 2017, 8:50 PM
bb added a subscriber: bb.

Notice we already have a big spelling cleanup revision under D589, but these changes aren't added there, so we can do it with this diff.

Please add yourself in the programming.json, so you end up in the credits!

Further grepping says patch is complete (as in all occurrences of "defintions" are removed)

source/graphics/ColladaManager.cpp
1 ↗(On Diff #3933)

when changing .cpp/.h update the license year (even when changing 2 characters :P)

Dunedan accepted this revision.Oct 26 2017, 5:34 PM
This revision is now accepted and ready to land.Oct 26 2017, 5:34 PM
elexis accepted this revision.Oct 29 2017, 12:32 AM
elexis added a subscriber: elexis.

No need for three patches (D974 and D975, with mutual merge conflicts).
Take care to upload patches always from the root directory.
More importantly upload the patches for the most recent svn or git version, not for alpha 22. These patches can't be applied anymore.
Other than that, thanks for running the spell checker and reporting.

This revision was automatically updated to reflect the committed changes.