Most images in art/textures/ui/session/portraits/units/ follow a consistent naming scheme, and their names typically match those of the template which use them. However, there were inconsistencies, e.g. the icon of the Carthaginian War elephant was called
cart_champion_cavalry.png
which is confusing for two reasons:
- the cart_champion_cavalry.xml template is the Sacred Band cavalry
- other champion elephant icons are named {civ}_champion_elephant.png
This patch changes a dozen or so (one of them unused) confusing and irregular names to match the regular naming scheme of the other unit portraits.