Differential D2491 Diff 10673 libraries/source/nvtt/src/src/nvmath/nvmath.h

Changeset View

Standalone View

libraries/source/nvtt/src/src/nvmath/nvmath.h

Context not available.
	{	{
	#if NV_OS_WIN32	#if NV_OS_WIN32
	return _isnan(f) != 0;	return _isnan(f) != 0;
	#elif NV_OS_DARWIN \|\| NV_OS_FREEBSD \|\| NV_OS_OPENBSD	#elif NV_OS_DARWIN \|\| NV_OS_FREEBSD \|\| NV_OS_OPENBSD \|\| NV_OS_LINUX
		vladislavbelovUnsubmitted Not Done Inline Actions This seems to be fixed in D2475. vladislavbelov: This seems to be fixed in D2475.
		voroskoiAuthorUnsubmitted Not Done Inline Actions I do not get it, sorry. voroskoi: I do not get it, sorry.
		vladislavbelovUnsubmitted Not Done Inline Actions I mean the patch https://code.wildfiregames.com/D2475 updates NVTT library. So maybe it's not needed to update the file yet (and do it after update). Also why not `isnanf` on Linux? It seems the most suitable function for the `const float` type. vladislavbelov: I mean the patch https://code.wildfiregames.com/D2475 updates NVTT library. So maybe it's not…
		linkmauveUnsubmitted Not Done Inline Actions `isnan()`, `isnanf()` and `isnanfl()` are obsolete since C99 introduced the `isnan()` macro which depends on the type of its input. linkmauve: `isnan()`, `isnanf()` and `isnanfl()` are obsolete since C99 introduced the `isnan()` macro…
		voroskoiAuthorUnsubmitted Not Done Inline Actions I have seen the linked patch, but I have not seen any change in it related the isnanf issue. nvtt git HEAD still uses isnanf() on linux, so upgrading nvtt will not be enough IMO. voroskoi: I have seen the linked patch, but I have not seen any change in it related the isnanf issue.
		ItmsUnsubmitted Not Done Inline Actions Whoops we commented at the same time. I will include this patch in the NVTT upgrade then. Itms: Whoops we commented at the same time. I will include this patch in the NVTT upgrade then.
		StanUnsubmitted Not Done Inline Actions What that means if we have another patch that fixes it :) Stan: What that means if we have another patch that fixes it :)
	return isnan(f);	return isnan(f);
	#elif NV_OS_LINUX
	return isnanf(f);
	#else	#else
	# error "isNan not supported"	# error "isNan not supported"
	#endif	#endif
Context not available.