Changeset View
Standalone View
binaries/data/mods/public/simulation/templates/structures/ptol_lighthouse.xml
Show All 12 Lines | <Health> | ||||
<SpawnEntityOnDeath>decay|rubble/rubble_stone_4x6</SpawnEntityOnDeath> | <SpawnEntityOnDeath>decay|rubble/rubble_stone_4x6</SpawnEntityOnDeath> | ||||
</Health> | </Health> | ||||
<Identity> | <Identity> | ||||
<Civ>ptol</Civ> | <Civ>ptol</Civ> | ||||
<GenericName>Lighthouse</GenericName> | <GenericName>Lighthouse</GenericName> | ||||
<SpecificName>Pharos</SpecificName> | <SpecificName>Pharos</SpecificName> | ||||
<Classes datatype="tokens">Lighthouse</Classes> | <Classes datatype="tokens">Lighthouse</Classes> | ||||
<VisibleClasses datatype="tokens">-City Town</VisibleClasses> | <VisibleClasses datatype="tokens">-City Town</VisibleClasses> | ||||
<Tooltip>Build along the shore to reveal the shorelines over the entire map. Very large vision range: 180 meters.</Tooltip> | <Tooltip>Build upon a shoreline in own, neutral, or allied territory. Reveal the shorelines over the entire map. Very large vision range.</Tooltip> | ||||
Gallaecio: I wonder if we should order words about territory ownership as follows: own, allied, neutral… | |||||
Not Done Inline Actions+1 Freagarach: +1 | |||||
Done Inline ActionsJust to be clear, neutral mean's no man's land, not the territory of neutral players.
Basically the order is from more to less likely. That it's revered alphabetical is a coincidence. An argument in favour of listing ally before neutral is that's the order in simulation/components/BuildRestrictions.js, though that could easily be rearranged, if deemed necessary. Nescio: Just to be clear, neutral mean's no man's land, //not// the territory of neutral players.
I've… | |||||
Not Done Inline ActionsI still prefer and order based on owner affinity, so while neutral before allied may make sense since neutral here means no-man’s land, I would still put enemy last. I do not have a strong opinion about it, though, so if you still prefer “own, neutral, enemy, allied” I won’t oppose. I do wonder, given that there can be neutral players, if we should find an alternative to ‘neutral’ for this use case, and leave ‘neutral’ to refer to territory of neutral players. ‘Unclaimed’, maybe? Gallaecio: I still prefer and order based on owner affinity, so while neutral before allied may make sense… | |||||
Done Inline Actions
Which is exactly why I prefer this order:
There aren't any structures buildable both in ally and enemy territory, though.
The automatically generated tooltips use those precise words: Therefore I'd strongly recommend sticking with that to avoid unnecessary confusion. If you want to use a different word, then it has to be changed in the relevant JavaScript code files, i.e. beyond the scope of this patch. Interestingly, the territory of neutral players is considered “enemy” territory. I guess that makes sense, because you don't share anything with them, unlike allies, so their territory is as hostile as that of enemies. Though maybe there ought to be a separate case for the territory of neutral players? I don't know. If desired, again something to change in the JS code, thus outside the scope of this patch. Nescio: >I still prefer and order based on owner affinity
Which is exactly why I prefer this order:
*… | |||||
<Icon>structures/lighthouse.png</Icon> | <Icon>structures/lighthouse.png</Icon> | ||||
<RequiredTechnology>phase_town</RequiredTechnology> | <RequiredTechnology>phase_town</RequiredTechnology> | ||||
</Identity> | </Identity> | ||||
<Loot> | <Loot> | ||||
<wood>0</wood> | <wood>0</wood> | ||||
<stone>50</stone> | <stone>50</stone> | ||||
<metal>50</metal> | <metal>50</metal> | ||||
</Loot> | </Loot> | ||||
Show All 27 Lines |
I wonder if we should order words about territory ownership as follows: own, allied, neutral, enemy.