Differential D2597 Diff 11440 binaries/data/mods/public/simulation/components/GarrisonHolder.js

Changeset View

Standalone View

binaries/data/mods/public/simulation/components/GarrisonHolder.js

Show First 20 Lines • Show All 685 Lines • ▼ Show 20 Lines	GarrisonHolder.prototype.IsEjectable = function(entity)

let ejectableClasses = this.template.EjectClassesOnDestroy._string;		let ejectableClasses = this.template.EjectClassesOnDestroy._string;
let entityClasses = Engine.QueryInterface(entity, IID_Identity).GetClassesList();		let entityClasses = Engine.QueryInterface(entity, IID_Identity).GetClassesList();

return MatchesClassList(entityClasses, ejectableClasses);		return MatchesClassList(entityClasses, ejectableClasses);
};		};

/**		/**
		* Sets the intitGarrison to the specified entities. Used by the mapreader.
		*
		* @param {number[]} entities - The entity IDs to garrison on init.
		*/
		GarrisonHolder.prototype.SetInitGarrison = function(entities)
		SilierUnsubmitted Done Inline Actions The name says `add` but comment and code says `set` Silier: The name says `add` but comment and code says `set`
		{
		this.initGarrison = entities;
		SilierUnsubmitted Done Inline Actions should clone to avoid issue from D2562 when some script decides to spawn entity with garrisoned entities and uses this function for it. Silier: should clone to avoid issue from D2562 when some script decides to spawn entity with garrisoned…
		};

		/**
* Initialise the garrisoned units.		* Initialise the garrisoned units.
*/		*/
GarrisonHolder.prototype.OnGlobalInitGame = function(msg)		GarrisonHolder.prototype.OnGlobalInitGame = function(msg)
{		{
if (!this.initGarrison)		if (!this.initGarrison)
		SilierUnsubmitted Done Inline Actions this is changing postcondition of the function. this.initGarrison was always undefined after this function was called, now it is not the case. Silier: this is changing postcondition of the function. this.initGarrison was always undefined after…
return;		return;

for (let ent of this.initGarrison)		for (let ent of this.initGarrison)
{		{
let cmpUnitAI = Engine.QueryInterface(ent, IID_UnitAI);		let cmpUnitAI = Engine.QueryInterface(ent, IID_UnitAI);
if (cmpUnitAI && cmpUnitAI.CanGarrison(this.entity) && this.Garrison(ent))		if (cmpUnitAI && cmpUnitAI.CanGarrison(this.entity) && this.Garrison(ent))
cmpUnitAI.Autogarrison(this.entity);		cmpUnitAI.Autogarrison(this.entity);
}		}
Show All 23 Lines