Differential D2995 Diff 13514 binaries/data/mods/public/simulation/templates/skirmish/units/default_infantry_melee_b.xml
Changeset View
Changeset View
Standalone View
Standalone View
binaries/data/mods/public/simulation/templates/skirmish/units/default_infantry_melee_b.xml
<?xml version="1.0" encoding="utf-8"?> | <?xml version="1.0" encoding="utf-8"?> | ||||
<Entity parent="template_unit_infantry_melee"> | <Entity parent="template_unit_infantry_melee"> | ||||
<Attack> | |||||
<Melee> | |||||
<AttackName>Melee</AttackName> | |||||
</Melee> | |||||
</Attack> | |||||
Nescio: Unnecessary, see parent. | |||||
Done Inline ActionsActually I don't see it in the parent. Neither I think it should be in the parent, since every child but this one will change it and this name is just a placeholder to be replaced by the correct template. bb: Actually I don't see it in the parent. Neither I think it should be in the parent, since every… | |||||
Not Done Inline ActionsThese skirmish/ templates are placeholders that are replaced during map generation. They don't contain any strings. Inserting an attack name here serves no function and is stricly speaking incorrect. Nescio: These skirmish/ templates are placeholders that are replaced during map generation. They don't… | |||||
Done Inline ActionsThe skirmish templates, while being replaced, still need to be a valid template, hence need some string here. bb: The skirmish templates, while being replaced, still need to be a valid template, hence need… | |||||
Not Done Inline ActionsThe string ought to be defined where the attack is defined, i.e. in the parent, not here. Nescio: The string ought to be defined where the attack is defined, i.e. in the parent, not here. | |||||
Not Done Inline ActionsI'm still not happy about this, but I suppose I can't convince you. Nescio: I'm still not happy about this, but I suppose I can't convince you. | |||||
<Identity> | <Identity> | ||||
<Civ>skirm</Civ> | <Civ>skirm</Civ> | ||||
</Identity> | </Identity> | ||||
<Promotion disable=""/> | <Promotion disable=""/> | ||||
<SkirmishReplacer> | <SkirmishReplacer> | ||||
<general>units/{civ}_infantry_spearman_b</general> | <general>units/{civ}_infantry_spearman_b</general> | ||||
</SkirmishReplacer> | </SkirmishReplacer> | ||||
<VisualActor> | <VisualActor> | ||||
<Actor>units/athenians/infantry_spearman_b.xml</Actor> | <Actor>units/athenians/infantry_spearman_b.xml</Actor> | ||||
</VisualActor> | </VisualActor> | ||||
</Entity> | </Entity> |
Wildfire Games · Phabricator
Unnecessary, see parent.