Changeset View
Standalone View
binaries/data/mods/public/simulation/templates/units/mace_champion_infantry_swordsman.xml
| <?xml version="1.0" encoding="utf-8"?> | <?xml version="1.0" encoding="utf-8"?> | ||||
| <Entity parent="template_unit_champion_infantry_swordsman"> | <Entity parent="template_unit_champion_infantry_swordsman"> | ||||
| <Attack> | |||||
| <Melee> | |||||
| <AttackName context="Name of an attack using a rhomphaia (ῥομφαία), a Thracian two-handed weapon capable of both thrusting and slashing.">Rhomphaia</AttackName> | |||||
Nescio: Maybe add context here too? I doubt everyone knows what a rhomphaia is. | |||||
Done Inline ActionsHappy to add context wherever needed. However if a translator doesn't know an english word, it isn't the job of the template changer to fix that, rather the translator needing to look up the meaning. Also note that all entries without a custom context (one in the template), gets name of an attack as context.Do you think there still is a need for some more context? If so do you have some proposal? (Adding something like Attack using a rhomphaia. doesn't seem to add any information) bb: Happy to add context wherever needed. However if a translator doesn't know an english word, it… | |||||
Not Done Inline ActionsThis particular weapon fell out of use before the English language existed. The point is “rhomphaia” is a technical term; you won't find it in an English dictionary. Therefore a bit of context could be helpful. Nescio: This particular weapon fell out of use before the English language existed. The point is… | |||||
Done Inline ActionsDo you have some string we can use here? A rhomphaia is a a sword like weapon.? Context on specific names can added very easily in a generic form (i.e, the same context for all templates): just add it in messages.json. Having the custom context like here, needs some code changes (similar to the ones here). In principle not too hard too do. Maybe make a ticket? bb: Do you have some string we can use here? `A rhomphaia is a a sword like weapon.`?
Context on… | |||||
Not Done Inline ActionsA rhomphaia is actually a long blade on a short pole. One could say it's both a sword and a spear, or neither. Nescio: A rhomphaia is actually a long blade on a short pole. One could say it's both a sword and a… | |||||
Done Inline ActionsMaybe place the Greek inside parentheses? ... a rhomphaia (ῥομφαία), a Thracian ... Nescio: Maybe place the Greek inside parentheses? `... a rhomphaia (ῥομφαία), a Thracian ...` | |||||
| </Melee> | |||||
| </Attack> | |||||
| <Identity> | <Identity> | ||||
| <Civ>mace</Civ> | <Civ>mace</Civ> | ||||
| <Lang>greek</Lang> | <Lang>greek</Lang> | ||||
| <GenericName>Thracian Black Cloak</GenericName> | <GenericName>Thracian Black Cloak</GenericName> | ||||
| <SpecificName>Rhomphaiaphoros</SpecificName> | <SpecificName>Rhomphaiaphoros</SpecificName> | ||||
| <SelectionGroupName>units/mace_champion_infantry_swordsman</SelectionGroupName> | <SelectionGroupName>units/mace_champion_infantry_swordsman</SelectionGroupName> | ||||
| <Icon>units/sele_infantry_swordsman.png</Icon> | <Icon>units/sele_infantry_swordsman.png</Icon> | ||||
| </Identity> | </Identity> | ||||
| <VisualActor> | <VisualActor> | ||||
| <Actor>units/hellenes/infantry_swordsman_c_thracian_blackcloak.xml</Actor> | <Actor>units/hellenes/infantry_swordsman_c_thracian_blackcloak.xml</Actor> | ||||
| </VisualActor> | </VisualActor> | ||||
| </Entity> | </Entity> | ||||
Maybe add context here too? I doubt everyone knows what a rhomphaia is.