Differential D3184 Diff 14458 binaries/data/mods/public/gui/lobby/LobbyPage/Game.js

Changeset View

Standalone View

binaries/data/mods/public/gui/lobby/LobbyPage/Game.js

Show First 20 Lines • Show All 264 Lines • ▼ Show 20 Lines	class Game
}		}
}		}

/**		/**
* These are all keys that occur in a gamelist stanza sent by XPartaMupp.		* These are all keys that occur in a gamelist stanza sent by XPartaMupp.
*/		*/
Game.prototype.StanzaKeys = [		Game.prototype.StanzaKeys = [
"name",		"name",
"ip",		"useSTUN",
		SilierAuthorUnsubmitted Done Inline Actions remove Silier: remove
"port",		"port",
		bbUnsubmitted Done Inline Actions If one cares enough, one might move this to cpp too bb: If one cares enough, one might move this to cpp too
		SilierAuthorUnsubmitted Done Inline Actions in theory one could have more games on one server so we need this to select games from list, also not such issue knowing port does anything Silier: in theory one could have more games on one server so we need this to select games from list…
		ImarokUnsubmitted Done Inline Actions That's no argument against moving it to cpp. From a security point of view the port shouldn't matter, so it could stay in js. From a consistency point of view it might make sense to move it to cpp as well. I can't say for sure without looking deeper into the code. Imarok: That's no argument against moving it to cpp. From a security point of view the port shouldn't…
		StanUnsubmitted Not Done Inline Actions Well if you know a vulnerability in gloox or whatever and you get the port it might give attackers an advantage. Anything that's not needed must go I think. Stan: Well if you know a vulnerability in gloox or whatever and you get the port it might give…
		ImarokUnsubmitted Done Inline Actions Nope. Gloox is used for xmpp. Maybe you mean enet? And without an IP the port doesn't give you anything. Imarok: Nope. Gloox is used for xmpp. Maybe you mean enet? And without an IP the port doesn't give you…
		StanUnsubmitted Done Inline Actions Right it seems XMPP doesn't send the IP by default (that's good) :) https://stackoverflow.com/questions/14496093/how-to-get-ip-address-of-chat-message-sender-using-xmpp-protocol-in-google-app-e Sure. But let's not make it any easier :) Stan: Right it seems XMPP doesn't send the IP by default (that's good) :) https://stackoverflow.
		lyvUnsubmitted Done Inline Actions That's not 100% accurate assesment, while the XMPP standard doesn't have IP information, the 0AD lobby xmpp server loads a module which attachs the sender's IP to game registration stanzas. lyv: That's not 100% accurate assesment, while the XMPP standard doesn't have IP information, the…
		SilierAuthorUnsubmitted Done Inline Actions he said by default, 0ad module is not default of xmpp Silier: he said by default, 0ad module is not default of xmpp
		lyvUnsubmitted Done Inline Actions The locally running ejabberd server and what it does holds more ground than the standard in my opinion. Therefore, the logical and prudent assumption is to not assume none of the stanzas have IP information. Why does it matter what the standard says, the only thing that matters is the current implementation. And therefore, whether or not XMPP standards say that IPs are included is not relevant if the implementation ends up attaching the information anyway. What exactly is the objective here and what are the problems being solved? lyv: The locally running ejabberd server and what it does holds more ground than the standard in my…
"stunIP",
"stunPort",		"stunPort",
		SilierAuthorUnsubmitted Done Inline Actions remove Silier: remove
		SilierAuthorUnsubmitted Done Inline Actions remove Silier: remove
"hostUsername",		"hostUsername",
"state",		"state",
"nbp",		"nbp",
"maxnbp",		"maxnbp",
"players",		"players",
"mapName",		"mapName",
"niceMapName",		"niceMapName",
"mapSize",		"mapSize",
▲ Show 20 Lines • Show All 57 Lines • Show Last 20 Lines