Changeset View
Changeset View
Standalone View
Standalone View
binaries/data/mods/public/gui/session/session.xml
<?xml version="1.0" encoding="UTF-8"?> | <?xml version="1.0" encoding="UTF-8"?> | ||||
<objects> | <objects> | ||||
<script directory="gui/common/"/> | <script directory="gui/common/"/> | ||||
<script directory="gui/common/campaigns/"/> | |||||
<script directory="gui/session/"/> | <script directory="gui/session/"/> | ||||
<script directory="gui/session/campaigns/"/> | |||||
<script directory="gui/session/chat/"/> | <script directory="gui/session/chat/"/> | ||||
<script directory="gui/session/developer_overlay/"/> | <script directory="gui/session/developer_overlay/"/> | ||||
<script directory="gui/session/diplomacy/"/> | <script directory="gui/session/diplomacy/"/> | ||||
<script directory="gui/session/diplomacy/playercontrols/"/> | <script directory="gui/session/diplomacy/playercontrols/"/> | ||||
<script directory="gui/session/lobby/"/> | <script directory="gui/session/lobby/"/> | ||||
<script directory="gui/session/lobby/LobbyRatingReport/"/> | <script directory="gui/session/lobby/LobbyRatingReport/"/> | ||||
<script directory="gui/session/message_box/"/> | <script directory="gui/session/message_box/"/> | ||||
<script directory="gui/session/minimap/"/> | <script directory="gui/session/minimap/"/> | ||||
<script directory="gui/session/objectives/"/> | <script directory="gui/session/objectives/"/> | ||||
<script directory="gui/session/top_panel/"/> | <script directory="gui/session/top_panel/"/> | ||||
<script directory="gui/session/top_panel/IconButtons/"/> | <script directory="gui/session/top_panel/IconButtons/"/> | ||||
<script directory="gui/session/trade/"/> | <script directory="gui/session/trade/"/> | ||||
elexis: -\n | |||||
<object name="session"> | <object name="session"> | ||||
Not Done Inline ActionsThis include shouldn't be here. gui/campaign/ should contain everything and only that which page_campaign.xml uses. I don't know which functions you use here, but possibly gui/common/campaign.js if its only one or two functions. elexis: This include shouldn't be here. `gui/campaign/` should contain everything and only that which… | |||||
Not Done Inline ActionsI'll check if it's needed at all. Don't remember why I added it a solid 2 years ago. wraitii: I'll check if it's needed at all. Don't remember why I added it a solid 2 years ago. | |||||
Not Done Inline ActionsSame (both why+directory). elexis: Same (both why+directory).
It sounds like this should be moved to common/ | |||||
Not Done Inline ActionsAlso io.js sounds a lot like bytestream, perhaps file, load or vfs would be a more common term? elexis: Also `io.js` sounds a lot like bytestream, perhaps `file`, `load` or `vfs` would be a more… | |||||
Done Inline ActionsThese are needed to pass the end game data. wraitii: These are needed to pass the end game data. | |||||
Not Done Inline ActionsThe io remark was about the name. I/O typically describes hardware. elexis: The `io` remark was about the name. I/O typically describes hardware. | |||||
<action on="Tick"> | <action on="Tick"> | ||||
onTick(); | onTick(); | ||||
</action> | </action> | ||||
<action on="SavegameLoaded"> | <action on="SavegameLoaded"> | ||||
restoreSavedGameData(arguments[0]); | restoreSavedGameData(arguments[0]); | ||||
</action> | </action> | ||||
▲ Show 20 Lines • Show All 83 Lines • Show Last 20 Lines |
Wildfire Games · Phabricator
-\n