Changeset View
Standalone View
binaries/data/mods/public/gui/lobby/LobbyPage/Game.js
Show First 20 Lines • Show All 263 Lines • ▼ Show 20 Lines | getTranslatedPlayerCount(newStanza) | ||||
return sprintf(txt, playerCountArgs); | return sprintf(txt, playerCountArgs); | ||||
} | } | ||||
} | } | ||||
/** | /** | ||||
* These are all keys that occur in a gamelist stanza sent by XPartaMupp. | * These are all keys that occur in a gamelist stanza sent by XPartaMupp. | ||||
*/ | */ | ||||
Game.prototype.StanzaKeys = [ | Game.prototype.StanzaKeys = [ | ||||
"name", | "name", | ||||
"ip", | "password", | ||||
bb: If one cares enough, one might move this to cpp too | |||||
Done Inline Actionsin theory one could have more games on one server so we need this to select games from list, also not such issue knowing port does anything Silier: in theory one could have more games on one server so we need this to select games from list… | |||||
Done Inline ActionsThat's no argument against moving it to cpp. Imarok: That's no argument against moving it to cpp.
From a security point of view the port shouldn't… | |||||
Not Done Inline ActionsWell if you know a vulnerability in gloox or whatever and you get the port it might give attackers an advantage. Anything that's not needed must go I think. Stan: Well if you know a vulnerability in gloox or whatever and you get the port it might give… | |||||
Done Inline ActionsNope. Imarok: Nope.
Gloox is used for xmpp.
Maybe you mean enet?
And without an IP the port doesn't give you… | |||||
Done Inline ActionsRight it seems XMPP doesn't send the IP by default (that's good) :) Sure. But let's not make it any easier :) Stan: Right it seems XMPP doesn't send the IP by default (that's good) :)
https://stackoverflow. | |||||
Done Inline ActionsThat's not 100% accurate assesment, while the XMPP standard doesn't have IP information, the 0AD lobby xmpp server loads a module which attachs the sender's IP to game registration stanzas. lyv: That's not 100% accurate assesment, while the XMPP standard doesn't have IP information, the… | |||||
Done Inline Actionshe said by default, 0ad module is not default of xmpp Silier: he said by default, 0ad module is not default of xmpp | |||||
Done Inline ActionsThe locally running ejabberd server and what it does holds more ground than the standard in my opinion. Therefore, the logical and prudent assumption is to not assume none of the stanzas have IP information. Why does it matter what the standard says, the only thing that matters is the current implementation. And therefore, whether or not XMPP standards say that IPs are included is not relevant if the implementation ends up attaching the information anyway. What exactly is the objective here and what are the problems being solved? lyv: The locally running ejabberd server and what it does holds more ground than the standard in my… | |||||
Done Inline Actionsremove Silier: remove | |||||
Done Inline Actionsremove Silier: remove | |||||
Done Inline Actionsremove Silier: remove | |||||
"port", | |||||
"stunIP", | |||||
"stunPort", | |||||
"hostUsername", | "hostUsername", | ||||
"state", | "state", | ||||
"nbp", | "nbp", | ||||
"maxnbp", | "maxnbp", | ||||
"players", | "players", | ||||
"mapName", | "mapName", | ||||
"niceMapName", | "niceMapName", | ||||
"mapSize", | "mapSize", | ||||
▲ Show 20 Lines • Show All 57 Lines • Show Last 20 Lines |
If one cares enough, one might move this to cpp too