Changeset View
Changeset View
Standalone View
Standalone View
binaries/data/mods/public/simulation/components/UnitAI.js
| Show First 20 Lines • Show All 333 Lines • ▼ Show 20 Lines | if (this.CanPack()) | |||||||||
| return; | return; | |||||||||
| } | } | |||||||||
| if (this.CheckRange(this.order.data)) | if (this.CheckRange(this.order.data)) | |||||||||
| { | { | |||||||||
| // We are already at the target, or can't move at all | // We are already at the target, or can't move at all | |||||||||
| this.FinishOrder(); | this.FinishOrder(); | |||||||||
| return true; | return true; | |||||||||
Lint: ESLintBear (consistent-return): `Method 'Order.WalkToTarget' expected no return value.` | ||||||||||
| } | } | |||||||||
| this.order.data.relaxed = true; | this.order.data.relaxed = true; | |||||||||
| if (this.IsAnimal()) | if (this.IsAnimal()) | |||||||||
| this.SetNextState("ANIMAL.WALKING"); | this.SetNextState("ANIMAL.WALKING"); | |||||||||
| else | else | |||||||||
| this.SetNextState("INDIVIDUAL.WALKING"); | this.SetNextState("INDIVIDUAL.WALKING"); | |||||||||
| ▲ Show 20 Lines • Show All 426 Lines • ▼ Show 20 Lines | "Order.Garrison": function(msg) { | |||||||||
| if (!this.CheckGarrisonRange(msg.data.target)) | if (!this.CheckGarrisonRange(msg.data.target)) | |||||||||
| { | { | |||||||||
| if (!this.CheckTargetVisible(msg.data.target)) | if (!this.CheckTargetVisible(msg.data.target)) | |||||||||
| { | { | |||||||||
| this.FinishOrder(); | this.FinishOrder(); | |||||||||
| return; | return; | |||||||||
| } | } | |||||||||
| else | else | |||||||||
| { | { | |||||||||
Lint: ESLintBear (no-else-return) Unnecessary 'else' after 'return'. Lint: ESLintBear (no-else-return): `Unnecessary 'else' after 'return'.` | ||||||||||
| this.SetNextState("GARRISON.APPROACHING"); | this.SetNextState("GARRISON.APPROACHING"); | |||||||||
| return; | return; | |||||||||
| } | } | |||||||||
| } | } | |||||||||
| this.SetNextState("GARRISON.GARRISONING"); | this.SetNextState("GARRISON.GARRISONING"); | |||||||||
| }, | }, | |||||||||
| ▲ Show 20 Lines • Show All 126 Lines • ▼ Show 20 Lines | "IDLE": { | |||||||||
| "enter": function(msg) { | "enter": function(msg) { | |||||||||
| // Turn rearrange off. Otherwise, if the formation is idle, | // Turn rearrange off. Otherwise, if the formation is idle, | |||||||||
| // but individual units go off to fight, any death | // but individual units go off to fight, any death | |||||||||
| // will rearrange the formation, looking odd. | // will rearrange the formation, looking odd. | |||||||||
| // Instead, move idle units in formation on a timer. | // Instead, move idle units in formation on a timer. | |||||||||
| let cmpFormation = Engine.QueryInterface(this.entity, IID_Formation); | let cmpFormation = Engine.QueryInterface(this.entity, IID_Formation); | |||||||||
| cmpFormation.SetRearrange(false); | cmpFormation.SetRearrange(false); | |||||||||
| this.StartTimer(0, 2000); | this.StartTimer(0, 2000); | |||||||||
| this.isIdle = true; | ||||||||||
| this.CallMemberFunction("ResetIdle"); | ||||||||||
| return false; | return false; | |||||||||
| }, | }, | |||||||||
| "leave": function() { | "leave": function() { | |||||||||
| this.isIdle = false; | ||||||||||
| this.StopTimer(); | this.StopTimer(); | |||||||||
| }, | }, | |||||||||
| "Timer": function(msg) { | "Timer": function(msg) { | |||||||||
| let cmpFormation = Engine.QueryInterface(this.entity, IID_Formation); | let cmpFormation = Engine.QueryInterface(this.entity, IID_Formation); | |||||||||
| if (!cmpFormation) | if (!cmpFormation) | |||||||||
| return; | return; | |||||||||
| ▲ Show 20 Lines • Show All 605 Lines • ▼ Show 20 Lines | "IDLE": { | |||||||||
| if (this.losRangeQuery) | if (this.losRangeQuery) | |||||||||
| cmpRangeManager.DisableActiveQuery(this.losRangeQuery); | cmpRangeManager.DisableActiveQuery(this.losRangeQuery); | |||||||||
| if (this.losHealRangeQuery) | if (this.losHealRangeQuery) | |||||||||
| cmpRangeManager.DisableActiveQuery(this.losHealRangeQuery); | cmpRangeManager.DisableActiveQuery(this.losHealRangeQuery); | |||||||||
| if (this.losAttackRangeQuery) | if (this.losAttackRangeQuery) | |||||||||
| cmpRangeManager.DisableActiveQuery(this.losAttackRangeQuery); | cmpRangeManager.DisableActiveQuery(this.losAttackRangeQuery); | |||||||||
| this.StopTimer(); | this.StopTimer(); | |||||||||
| if (this.isIdle) | ||||||||||
FreagarachUnsubmitted Not Done Inline ActionsWhy remove this? Freagarach: Why remove this? | ||||||||||
| { | ||||||||||
| this.isIdle = false; | this.isIdle = false; | |||||||||
| Engine.PostMessage(this.entity, MT_UnitIdleChanged, { "idle": this.isIdle }); | Engine.PostMessage(this.entity, MT_UnitIdleChanged, { "idle": this.isIdle }); | |||||||||
Not Done Inline ActionsThis is called often, so the function call is not nice, I think you can get away with some duplication (since this is merely called for idle units). Freagarach: This is called often, so the function call is not nice, I think you can get away with some… | ||||||||||
| } | ||||||||||
| }, | }, | |||||||||
| // On the range updates: | // On the range updates: | |||||||||
| // We check for idleness to prevent an entity to react only to newly seen entities | // We check for idleness to prevent an entity to react only to newly seen entities | |||||||||
| // when receiving a Los*RangeUpdate on the same turn as the entity becomes idle | // when receiving a Los*RangeUpdate on the same turn as the entity becomes idle | |||||||||
| // since this.FindNew*Targets is called in the timer. | // since this.FindNew*Targets is called in the timer. | |||||||||
| "LosRangeUpdate": function(msg) { | "LosRangeUpdate": function(msg) { | |||||||||
| Show All 39 Lines | "IDLE": { | |||||||||
| // Move back to the held position if we drifted away. | // Move back to the held position if we drifted away. | |||||||||
| // (only if not a formation member). | // (only if not a formation member). | |||||||||
| if (!this.IsFormationMember() && | if (!this.IsFormationMember() && | |||||||||
| this.GetStance().respondHoldGround && this.heldPosition && | this.GetStance().respondHoldGround && this.heldPosition && | |||||||||
| !this.CheckPointRangeExplicit(this.heldPosition.x, this.heldPosition.z, 0, 10) && | !this.CheckPointRangeExplicit(this.heldPosition.x, this.heldPosition.z, 0, 10) && | |||||||||
| this.WalkToHeldPosition()) | this.WalkToHeldPosition()) | |||||||||
| return; | return; | |||||||||
| if (this.IsFormationMember()) | ||||||||||
| { | ||||||||||
| let cmpFormationAI = Engine.QueryInterface(this.formationController, IID_UnitAI); | ||||||||||
| if (!cmpFormationAI || !cmpFormationAI.IsIdle()) | ||||||||||
| return; | ||||||||||
| } | ||||||||||
| this.isIdle = true; | this.isIdle = true; | |||||||||
| Engine.PostMessage(this.entity, MT_UnitIdleChanged, { "idle": this.isIdle }); | Engine.PostMessage(this.entity, MT_UnitIdleChanged, { "idle": this.isIdle }); | |||||||||
| } | } | |||||||||
| }, | }, | |||||||||
| }, | }, | |||||||||
| "WALKING": { | "WALKING": { | |||||||||
| "enter": function() { | "enter": function() { | |||||||||
| ▲ Show 20 Lines • Show All 514 Lines • ▼ Show 20 Lines | "COMBAT": { | |||||||||
| this.SetNextState("FINDINGNEWTARGET"); | this.SetNextState("FINDINGNEWTARGET"); | |||||||||
| }, | }, | |||||||||
| // TODO: respond to target deaths immediately, rather than waiting | // TODO: respond to target deaths immediately, rather than waiting | |||||||||
| // until the next Timer event | // until the next Timer event | |||||||||
| "Attacked": function(msg) { | "Attacked": function(msg) { | |||||||||
| if (this.order.data.attackType == "Capture" && (this.GetStance().targetAttackersAlways || !this.order.data.force) | if (this.order.data.attackType == "Capture" && (this.GetStance().targetAttackersAlways || !this.order.data.force) | |||||||||
| && this.order.data.target != msg.data.attacker && this.GetBestAttackAgainst(msg.data.attacker, true) != "Capture") | && this.order.data.target != msg.data.attacker && this.GetBestAttackAgainst(msg.data.attacker, true) != "Capture") | |||||||||
Lint: ESLintBear (operator-linebreak) '&&' should be placed at the end of the line. Lint: ESLintBear (operator-linebreak): `'&&' should be placed at the end of the line.` | ||||||||||
| this.RespondToTargetedEntities([msg.data.attacker]); | this.RespondToTargetedEntities([msg.data.attacker]); | |||||||||
| }, | }, | |||||||||
| }, | }, | |||||||||
| "FINDINGNEWTARGET": { | "FINDINGNEWTARGET": { | |||||||||
| "Order.Cheer": function() { | "Order.Cheer": function() { | |||||||||
| if (!this.cheeringTime) | if (!this.cheeringTime) | |||||||||
| return { "discardOrder": true }; | return { "discardOrder": true }; | |||||||||
| ▲ Show 20 Lines • Show All 1,373 Lines • ▼ Show 20 Lines | UnitAI.prototype.IsHealer = function() | |||||||||
| return Engine.QueryInterface(this.entity, IID_Heal); | return Engine.QueryInterface(this.entity, IID_Heal); | |||||||||
| }; | }; | |||||||||
| UnitAI.prototype.IsIdle = function() | UnitAI.prototype.IsIdle = function() | |||||||||
| { | { | |||||||||
| return this.isIdle; | return this.isIdle; | |||||||||
| }; | }; | |||||||||
| /** | ||||||||||
| * Used by formation controllers to toggle the idleness of their members. | ||||||||||
| */ | ||||||||||
| UnitAI.prototype.ResetIdle = function() | ||||||||||
| { | ||||||||||
| let shouldBeIdle = this.GetCurrentState().endsWith(".IDLE"); | ||||||||||
| if (this.isIdle == shouldBeIdle) | ||||||||||
| return; | ||||||||||
| this.isIdle = shouldBeIdle; | ||||||||||
| Engine.PostMessage(this.entity, MT_UnitIdleChanged, { "idle": this.isIdle }); | ||||||||||
FreagarachUnsubmitted Not Done Inline Actions
^ Freagarach: ^ | ||||||||||
| }; | ||||||||||
| UnitAI.prototype.IsGarrisoned = function() | UnitAI.prototype.IsGarrisoned = function() | |||||||||
| { | { | |||||||||
| return this.isGarrisoned; | return this.isGarrisoned; | |||||||||
| }; | }; | |||||||||
| UnitAI.prototype.SetGarrisoned = function() | UnitAI.prototype.SetGarrisoned = function() | |||||||||
| { | { | |||||||||
| this.isGarrisoned = true; | this.isGarrisoned = true; | |||||||||
| ▲ Show 20 Lines • Show All 3,013 Lines • Show Last 20 Lines | ||||||||||
Wildfire Games · Phabricator
Method 'Order.WalkToTarget' expected no return value.