Differential D3225 Diff 15473 binaries/data/mods/public/simulation/components/Attack.js

Changeset View

Standalone View

binaries/data/mods/public/simulation/components/Attack.js

Show First 20 Lines • Show All 509 Lines • ▼ Show 20 Lines	if (type == "Ranged")
// In the future this could be extended:		// In the future this could be extended:
// * Obstacles like trees could reduce the probability of the target being hit		// * Obstacles like trees could reduce the probability of the target being hit
// * Obstacles like walls should block projectiles entirely		// * Obstacles like walls should block projectiles entirely

let horizSpeed = +this.template[type].Projectile.Speed;		let horizSpeed = +this.template[type].Projectile.Speed;
let gravity = +this.template[type].Projectile.Gravity;		let gravity = +this.template[type].Projectile.Gravity;
// horizSpeed /= 2; gravity /= 2; // slow it down for testing		// horizSpeed /= 2; gravity /= 2; // slow it down for testing

		// We will try to estimate the position of the target, where we can hit it.
		// We first estimate the time-till-hit by extrapolating linearly the movement
		// of the last turn. We compute the time till an arrow will intersect the target.
let cmpPosition = Engine.QueryInterface(this.entity, IID_Position);		let cmpPosition = Engine.QueryInterface(this.entity, IID_Position);
if (!cmpPosition \|\| !cmpPosition.IsInWorld())		if (!cmpPosition \|\| !cmpPosition.IsInWorld())
return;		return;
let selfPosition = cmpPosition.GetPosition();		let selfPosition = cmpPosition.GetPosition();
let cmpTargetPosition = Engine.QueryInterface(target, IID_Position);		let cmpTargetPosition = Engine.QueryInterface(target, IID_Position);
if (!cmpTargetPosition \|\| !cmpTargetPosition.IsInWorld())		if (!cmpTargetPosition \|\| !cmpTargetPosition.IsInWorld())
return;		return;
let targetPosition = cmpTargetPosition.GetPosition();		let targetPosition = cmpTargetPosition.GetPosition();

let previousTargetPosition = Engine.QueryInterface(target, IID_Position).GetPreviousPosition();		let targetVelocity = Vector3D.sub(targetPosition, cmpTargetPosition.GetPreviousPosition()).div(turnLength);
let targetVelocity = Vector3D.sub(targetPosition, previousTargetPosition).div(turnLength);

let timeToTarget = PositionHelper.PredictTimeToTarget(selfPosition, horizSpeed, targetPosition, targetVelocity);		let timeToTarget = PositionHelper.PredictTimeToTarget(selfPosition, horizSpeed, targetPosition, targetVelocity);
let predictedPosition = (timeToTarget !== false) ? Vector3D.mult(targetVelocity, timeToTarget).add(targetPosition) : targetPosition;
		// 'Cheat' and use UnitMotion to predict the position in the near-future.
		// This avoids 'dancing' issues with units zigzagging over very short distances.
		// However, this could fail if the player gives several short move orders, so
		// occasionally fall back to basic interpolation.
		let predictedPosition = targetPosition;
		StanUnsubmitted Not Done Inline Actions Isn't that overriden everytime? Stan: Isn't that overriden everytime?
		wraitiiUnsubmitted Not Done Inline Actions not if time to target is false wraitii: not if time to target is false
		StanUnsubmitted Done Inline Actions I guess doing it here saves a else clause. Meh. Stan: I guess doing it here saves a else clause. Meh.
		if (timeToTarget !== false)
		StanUnsubmitted Not Done Inline Actions What values can that be? Stan: What values can that be?
		wraitiiUnsubmitted Not Done Inline Actions it can be false :p wraitii: it can be false :p
		StanUnsubmitted Not Done Inline Actions Can it be 0 ? I'm not sure about the check, it seems oddly specific ^^ Stan: Can it be 0 ? I'm not sure about the check, it seems oddly specific ^^
		wraitiiUnsubmitted Not Done Inline Actions It can if you check the code, because this is solving an equation and has a plausible 'target cannot be reached' outcome, which is 'false' case, as opposed to '0' which means 'it takes no time to reach the target' wraitii: It can if you check the code, because this is solving an equation and has a plausible 'target…
		{
		// Don't predict too far in the future, but avoid threshold effects.
		// After 1 second, always use the 'dumb' interpolated past-motion prediction.
		let useUnitMotion = randBool(Math.max(0, 0.75 - timeToTarget / 1.333));
		if (useUnitMotion)
		SilierUnsubmitted Not Done Inline Actions you could do if else and avoid calling IID_UnitMotion when not needed Silier: you could do if else and avoid calling IID_UnitMotion when not needed
		{
		let cmpTargetUnitMotion = Engine.QueryInterface(target, IID_UnitMotion);
		let cmpTargetUnitAI = Engine.QueryInterface(target, IID_UnitAI);
		if (cmpTargetUnitMotion && (!cmpTargetUnitAI \|\| !cmpTargetUnitAI.IsFormationMember()))
		{
		let pos2D = cmpTargetUnitMotion.EstimateFuturePosition(timeToTarget);
		predictedPosition.x = pos2D.x;
		predictedPosition.z = pos2D.y;
		}
		else
		predictedPosition = Vector3D.mult(targetVelocity, timeToTarget).add(targetPosition);
		StanUnsubmitted Not Done Inline Actions Do you still need 3D here and below? Stan: Do you still need 3D here and below?
		wraitiiUnsubmitted Not Done Inline Actions The predicted position is 3D wraitii: The predicted position is 3D
		}
		else
		predictedPosition = Vector3D.mult(targetVelocity, timeToTarget).add(targetPosition);
		}

// Add inaccuracy based on spread.		// Add inaccuracy based on spread.
let distanceModifiedSpread = ApplyValueModificationsToEntity("Attack/Ranged/Spread", +this.template[type].Projectile.Spread, this.entity) *		let distanceModifiedSpread = ApplyValueModificationsToEntity("Attack/Ranged/Spread", +this.template[type].Projectile.Spread, this.entity) *
predictedPosition.horizDistanceTo(selfPosition) / 100;		predictedPosition.horizDistanceTo(selfPosition) / 100;

let randNorm = randomNormal2D();		let randNorm = randomNormal2D();
let offsetX = randNorm[0] * distanceModifiedSpread;		let offsetX = randNorm[0] * distanceModifiedSpread;
let offsetZ = randNorm[1] * distanceModifiedSpread;		let offsetZ = randNorm[1] * distanceModifiedSpread;
▲ Show 20 Lines • Show All 97 Lines • Show Last 20 Lines