Changeset View
Changeset View
Standalone View
Standalone View
source/gui/CGUIText.cpp
/* Copyright (C) 2019 Wildfire Games. | /* Copyright (C) 2021 Wildfire Games. | ||||
* This file is part of 0 A.D. | * This file is part of 0 A.D. | ||||
* | * | ||||
* 0 A.D. is free software: you can redistribute it and/or modify | * 0 A.D. is free software: you can redistribute it and/or modify | ||||
Context not available. | |||||
void CGUIText::Draw(CGUI& pGUI, const CGUIColor& DefaultColor, const CPos& pos, const float z, const CRect& clipping) const | void CGUIText::Draw(CGUI& pGUI, const CGUIColor& DefaultColor, const CPos& pos, const float z, const CRect& clipping) const | ||||
{ | { | ||||
OGL_SCOPED_DEBUG_GROUP("Draw GUI text"); | |||||
vladislavbelov: I'd prefer single name macro instead of duplicating. And the `group` word is too common and… | |||||
CShaderTechniquePtr tech = g_Renderer.GetShaderManager().LoadEffect(str_gui_text); | CShaderTechniquePtr tech = g_Renderer.GetShaderManager().LoadEffect(str_gui_text); | ||||
Not Done Inline ActionsShould be removed, the GUI code shouldn't have GL related stuff. The same for other GUI changes. vladislavbelov: Should be removed, the GUI code shouldn't have GL related stuff. The same for other GUI changes. | |||||
tech->BeginPass(); | tech->BeginPass(); | ||||
Context not available. |
Wildfire Games · Phabricator
I'd prefer single name macro instead of duplicating. And the group word is too common and might be used in the code.