Changeset View
Standalone View
binaries/data/mods/public/gui/session/selection_panels.js
| Context not available. | |||||
| data.countDisplay.caption = data.item.count > 1 ? data.item.count : ""; | data.countDisplay.caption = data.item.count > 1 ? data.item.count : ""; | ||||
| // Show the progress number for the first item | // Show the time remaining to finish the first item | ||||
| if (data.i == 0) | if (data.i == 0) | ||||
| Engine.GetGUIObjectByName("queueProgress").caption = Math.round(data.item.progress*100) + "%"; | Engine.GetGUIObjectByName("queueTimeRemaining").caption = Engine.FormatMillisecondsIntoDateStringGMT(data.item.timeRemaining, translateWithContext("Time remaining countdown format", "m:ss")); | ||||
elexis: Notice how this number + "%" is totally broken translation-wise.
That was the only occurance of… | |||||
Not Done Inline ActionstranslaWithContext or translation comment elexis: translaWithContext or translation comment | |||||
Not Done Inline Actionsdata.item.progress: Good that you didn't removed the "progress" property in ProductionQueue.prototype.GetQueue, since that is still used by stopAllProduction in entity.js to stop all queues below 45% if the AI is rushed afaics. (Still wonder if it wouldn't be clener to return totalTime instead of the percent number, but not our business) String: Another option would be showing the total number of seconds and no minutes, i.e. 68 or 190 to avoid those other leading zeroes if it's less than a minute and less than 10 seconds (which should be the average case even) Context: elexis: **data.item.progress**: Good that you didn't removed the `"progress"` property in… | |||||
Not Done Inline ActionsMaybe rename queueProgress to queueTimeRemaining for the sake of consistency? scythetwirler: Maybe rename queueProgress to queueTimeRemaining for the sake of consistency? | |||||
| let guiObject = Engine.GetGUIObjectByName("unitQueueProgressSlider["+data.i+"]"); | let guiObject = Engine.GetGUIObjectByName("unitQueueProgressSlider["+data.i+"]"); | ||||
| let size = guiObject.size; | let size = guiObject.size; | ||||
| Context not available. | |||||
Notice how this number + "%" is totally broken translation-wise.
That was the only occurance of "%"
Those (escaped) percentage numbers in the translation strings: "%%" are unrelated, so all percent numbers are changed as far as I can see.
The construction rate, capture progress is seen in a status bar, but not printed explicitly, neither in the tooltips.