Differential D546 Diff 2210 binaries/data/mods/public/gui/gamesetup/gamesetup.js

Changeset View

Standalone View

binaries/data/mods/public/gui/gamesetup/gamesetup.js

Show First 20 Lines • Show All 1,273 Lines • ▼ Show 20 Lines	function handlePlayerAssignmentMessage(message)
if (playerChange)		if (playerChange)
sendRegisterGameStanzaImmediate();		sendRegisterGameStanzaImmediate();
else		else
sendRegisterGameStanza();		sendRegisterGameStanza();
}		}

function onClientJoin(newGUID, newAssignments)		function onClientJoin(newGUID, newAssignments)
{		{
		let playername = newAssignments[newGUID].name;

addChatMessage({		addChatMessage({
"type": "connect",		"type": "connect",
"guid": newGUID,		"guid": newGUID,
"username": newAssignments[newGUID].name		"username": playername
});		});

		let isRejoiningPlayer = newAssignments[newGUID].player != -1;

		// Assign the client (or only buddies if prefered) to an unused playerslot and rejoining players to their old slot
		SandaracUnsubmitted Done Inline Actions Useless comment. Sandarac: Useless comment.
		elexisAuthorUnsubmitted Not Done Inline Actions I'd lead to documenting this too much than too few, since iirc I introduced a bug that had to be fixed with D50 and caused me to post a code-travolta meme, so I'd rather avoid that with a comment. elexis: I'd lead to documenting this too much than too few, since iirc I introduced a bug that had to…
		if (!isRejoiningPlayer && playername != newAssignments[Engine.GetPlayerGUID()].name)
		SandaracUnsubmitted Done Inline Actions Wrong indentation. Sandarac: Wrong indentation.
		elexisAuthorUnsubmitted Not Done Inline Actions Guess this came from the lint patch I had let it apply when uploading with arc elexis: Guess this came from the lint patch I had let it apply when uploading with arc
		{
		let assignOption = Engine.ConfigDB_GetValue("user", "gui.gamesetup.assignplayers");
		if (assignOption == "noone" \|\|
		assignOption == "buddies" && g_Buddies.indexOf(splitRatingFromNick(playername)[0]) == -1)
		return;
		scythetwirlerUnsubmitted Done Inline Actions Indent? scythetwirler: Indent?
		elexisAuthorUnsubmitted Not Done Inline Actions ✓ elexis: ✓
		}

let freeSlot = g_GameAttributes.settings.PlayerData.findIndex((v,i) =>		let freeSlot = g_GameAttributes.settings.PlayerData.findIndex((v,i) =>
Object.keys(g_PlayerAssignments).every(guid => g_PlayerAssignments[guid].player != i+1)		Object.keys(g_PlayerAssignments).every(guid => g_PlayerAssignments[guid].player != i+1)
);		);

// Client is not and cannot become assigned as player		// Client is not and cannot become assigned as player
if (newAssignments[newGUID].player == -1 && freeSlot == -1)		if (!isRejoiningPlayer && freeSlot == -1)
return;		return;

// Assign the joining client to the free slot		// Assign the joining client to the free slot
if (g_IsController && newAssignments[newGUID].player == -1)		if (g_IsController && !isRejoiningPlayer)
Engine.AssignNetworkPlayer(freeSlot + 1, newGUID);		Engine.AssignNetworkPlayer(freeSlot + 1, newGUID);

resetReadyData();		resetReadyData();
}		}

function onClientLeave(guid)		function onClientLeave(guid)
{		{
addChatMessage({		addChatMessage({
▲ Show 20 Lines • Show All 958 Lines • Show Last 20 Lines