Changeset View
Standalone View
binaries/data/mods/public/gui/session/selection_panels_middle/single_details_area.xml
<?xml version="1.0" encoding="utf-8"?> | <?xml version="1.0" encoding="utf-8"?> | ||||
elexis: Rebase rP19649 | |||||
<!-- Unit details for Single Unit --> | <!-- Unit details for Single Unit --> | ||||
<object size="50%-112 0 50%+112 100%" name="detailsAreaSingle"> | <object size="50%-112 0 50%+112 100%" name="detailsAreaSingle"> | ||||
<!-- Stats Bars --> | <!-- Stats Bars --> | ||||
<object size= "2 0 100%-2 98" type="image" tooltip_style="sessionToolTip"> | <object size= "2 0 100%-2 98" type="image" tooltip_style="sessionToolTip"> | ||||
<object size="0 8 100% 60" type="image" sprite="edgedPanelShader"> | <object size="0 4 100% 64" type="image" sprite="topEdgedPanelShader"> | ||||
<!-- Placeholders to get the position for the bars --> | |||||
elexisUnsubmitted Done Inline Actions"Placeholders storing the"...? elexis: "Placeholders storing the"...?
| |||||
<object size="88 1 100% 24" name="sectionPosTop"/> | |||||
<object size="88 11 100% 34" name="sectionPosMiddle"/> | |||||
<object size="88 32 100% 55" name="sectionPosBottom"/> | |||||
elexisUnsubmitted Done Inline ActionsShould those be hidden? It's not required as they aren't ghostbusters, but might still be cleaner (expresses intent and might save some microseconds) elexis: Should those be hidden? It's not required as they aren't ghostbusters, but might still be… | |||||
Done Inline Actionshidden="false" unneeded, isnt it? elexis: hidden="false" unneeded, isnt it? | |||||
<!-- Health bar --> | <!-- Health bar --> | ||||
<object size="88 0 100% 24" name="healthSection"> | <object size="88 1 100% 24" name="healthSection"> | ||||
elexisUnsubmitted Done Inline ActionsAs yelled at above, remove the duplicate size elexis: As yelled at above, remove the duplicate size | |||||
ImarokAuthorUnsubmitted Not Done Inline ActionsWow, I didn't knew, you can totally remove the size tag :D Imarok: Wow, I didn't knew, you can totally remove the size tag :D
(But now thinking about it its… | |||||
<object size="0 0 100% 16" name="healthLabel" type="text" style="StatsTextLeft" ghost="true"> | <object size="0 0 100% 12" name="healthLabel" type="text" style="StatsTextLeft" ghost="true"> | ||||
<translatableAttribute id="tooltip">Health:</translatableAttribute> | <translatableAttribute id="tooltip">Health:</translatableAttribute> | ||||
</object> | </object> | ||||
<object size="0 0 100% 16" name="healthStats" type="text" style="StatsTextRight" ghost="true"/> | <object size="0 0 100% 12" name="healthStats" type="text" style="StatsTextRight" ghost="true"/> | ||||
<object size="1 16 100% 23" name="health" type="image" tooltip_style="sessionToolTip"> | <object size="1 14 100% 21" name="health" type="image" tooltip_style="sessionToolTip"> | ||||
<object type="image" sprite="barBorder" ghost="true" size="-1 -1 100%+1 100%+1"/> | <object type="image" sprite="barBorder" ghost="true" size="-1 -1 100%+1 100%+1"/> | ||||
<object type="image" sprite="healthBackground" ghost="true"/> | <object type="image" sprite="healthBackground" ghost="true"/> | ||||
<object type="image" sprite="healthForeground" ghost="true" name="healthBar"/> | <object type="image" sprite="healthForeground" ghost="true" name="healthBar"/> | ||||
<object type="image" sprite="statsBarShaderHorizontal" ghost="true"/> | <object type="image" sprite="statsBarShaderHorizontal" ghost="true"/> | ||||
</object> | </object> | ||||
</object> | </object> | ||||
<!-- Capture bar --> | <!-- Capture bar --> | ||||
<object size="88 28 100% 52" name="captureSection"> | <object size="88 1 100% 24" name="captureSection"> | ||||
elexisUnsubmitted Done Inline Actionsand here elexis: and here | |||||
<object size="0 0 100% 16" name="captureLabel" type="text" style="StatsTextLeft" ghost="true"> | <object size="0 0 100% 12" name="captureLabel" type="text" style="StatsTextLeft" ghost="true"> | ||||
<translatableAttribute id="tooltip">Capture points:</translatableAttribute> | <translatableAttribute id="tooltip">Capture points:</translatableAttribute> | ||||
</object> | </object> | ||||
<object size="0 0 100% 16" name="captureStats" type="text" style="StatsTextRight" ghost="true"/> | <object size="0 0 100% 12" name="captureStats" type="text" style="StatsTextRight" ghost="true"/> | ||||
<object size="1 16 100% 23" name="capture" type="image"> | <object size="1 14 100% 21" name="capture" type="image" tooltip_style="sessionToolTip"> | ||||
<object type="image" sprite="barBorder" ghost="true" size="-1 -1 100%+1 100%+1"/> | <object type="image" sprite="barBorder" ghost="true" size="-1 -1 100%+1 100%+1"/> | ||||
<repeat count="9"> | <repeat count="9"> | ||||
<object type="image" sprite="playerColorBackground" ghost="true" name="captureBar[n]" hidden="true"/> | <object type="image" sprite="playerColorBackground" ghost="true" name="captureBar[n]" hidden="true"/> | ||||
</repeat> | </repeat> | ||||
<object type="image" sprite="statsBarShaderHorizontal" ghost="true"/> | <object type="image" sprite="statsBarShaderHorizontal" ghost="true"/> | ||||
</object> | </object> | ||||
</object> | </object> | ||||
<!-- Resource bar --> | <!-- Resource bar --> | ||||
<object size="88 28 100% 52" name="resourceSection"> | <object size="88 1 100% 24" name="resourceSection"> | ||||
elexisUnsubmitted Done Inline Actionsand here elexis: and here | |||||
<object size="0 0 100% 16" name="resourceLabel" type="text" style="StatsTextLeft" ghost="true"/> | <object size="0 0 100% 12" name="resourceLabel" type="text" style="StatsTextLeft" ghost="true"/> | ||||
<object size="0 0 100% 16" name="resourceStats" type="text" style="StatsTextRight" ghost="true"/> | <object size="0 0 100% 12" name="resourceStats" type="text" style="StatsTextRight" ghost="true"/> | ||||
<object size="1 16 100% 23" name="resources" type="image"> | <object size="1 14 100% 21" name="resources" type="image"> | ||||
<object type="image" sprite="barBorder" ghost="true" size="-1 -1 100%+1 100%+1"/> | <object type="image" sprite="barBorder" ghost="true" size="-1 -1 100%+1 100%+1"/> | ||||
<object type="image" sprite="resourceBackground" ghost="true"/> | <object type="image" sprite="resourceBackground" ghost="true"/> | ||||
<object type="image" sprite="resourceForeground" ghost="true" name="resourceBar"/> | <object type="image" sprite="resourceForeground" ghost="true" name="resourceBar"/> | ||||
<object type="image" sprite="statsBarShaderHorizontal" ghost="true"/> | <object type="image" sprite="statsBarShaderHorizontal" ghost="true"/> | ||||
</object> | </object> | ||||
</object> | </object> | ||||
</object> | </object> | ||||
<object size="0 60 100% 96" type="image" sprite="edgedPanelShader"> | <object size="0 63 100% 99" type="image" sprite="edgedPanelShader"> | ||||
Not Done Inline ActionsThat sounds like a workaround. Those numbers are duplicates of resourceSection and captureSection, it must be possible to get rid of these mock GUI objects with the duplicate numbers. Don't you only need to modify the Y coordinates by +12px? i.e. resourceLabel.height or some of the other ones of that height? elexis: That sounds like a workaround. Those numbers are duplicates of `resourceSection` and… | |||||
Not Done Inline ActionsWon't work without hardcoding numbers in js Imarok: Won't work without hardcoding numbers in js | |||||
Done Inline ActionsIf we have to do this, then I'd suggest to remove the duplicate numbers from the bars and move those 2 objects to the top and add a short XML comment stating what they do. sectionPosMiddle and sectionPosBottom? How about adding `sectionPosTop too and removing the Health one too, so as to unify them? elexis: If we have to do this, then I'd suggest to remove the duplicate numbers from the bars and move… | |||||
<!-- Attack and Armor --> | <!-- Attack and Armor --> | ||||
<object size="90 -2 126 34" name="attackAndArmorStats" type="image" sprite="stretched:session/icons/stances/defensive.png" tooltip_style="sessionToolTipInstantly"> | <object size="90 -2 126 34" name="attackAndArmorStats" type="image" sprite="stretched:session/icons/stances/defensive.png" tooltip_style="sessionToolTipInstantly"> | ||||
<translatableAttribute id="tooltip">Attack and Armor</translatableAttribute> | <translatableAttribute id="tooltip">Attack and Armor</translatableAttribute> | ||||
</object> | </object> | ||||
<!-- Resource carrying icon/counter --> | <!-- Resource carrying icon/counter --> | ||||
<!-- Used also for number of gatherers/builders --> | <!-- Used also for number of gatherers/builders --> | ||||
<object size="100%-98 -2 100%-28 34" type="text" name="resourceCarryingText" style="CarryingTextRight"/> | <object size="100%-98 -2 100%-28 34" type="text" name="resourceCarryingText" style="CarryingTextRight"/> | ||||
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines |
Rebase rP19649