Changeset View
Changeset View
Standalone View
Standalone View
binaries/data/mods/public/simulation/components/Attack.js
| Show First 20 Lines • Show All 714 Lines • ▼ Show 20 Lines | |||||||||
| /** | /** | ||||||||
| * @param {number} - The entity ID of the target to check. | * @param {number} - The entity ID of the target to check. | ||||||||
| * @return {boolean} - Whether this entity is in range of its target. | * @return {boolean} - Whether this entity is in range of its target. | ||||||||
| */ | */ | ||||||||
| Attack.prototype.IsTargetInRange = function(target, type) | Attack.prototype.IsTargetInRange = function(target, type) | ||||||||
| { | { | ||||||||
| let range = this.GetRange(type); | let range = this.GetRange(type); | ||||||||
| if (type == "Ranged") | let parabolicMaxRange = Math.max(0, Engine.QueryInterface(SYSTEM_ENTITY, IID_RangeManager).GetEffectiveParabolicRange(this.entity, target, range.max, range.elevationBonus)); | ||||||||
Lint: prefer-const: 'parabolicMaxRange' is never reassigned. Use 'const' instead. | |||||||||
| { | return parabolicMaxRange >= 0 && Engine.QueryInterface(SYSTEM_ENTITY, IID_ObstructionManager).IsInTargetRange( | ||||||||
Not Done Inline ActionsIsn't it always >= 0 ? Since you math.maxed it ? Stan: Isn't it always >= 0 ? Since you math.maxed it ?
Wonder if we shouldn't have a function for… | |||||||||
Done Inline Actionswe shouldn't do math.max in the first place The only gain of such a cpp function for now is one less ccp/js conversion. Ideally we did be avoiding sqrt's too bb: we shouldn't do math.max in the first place
The only gain of such a cpp function for now is… | |||||||||
| let cmpPositionTarget = Engine.QueryInterface(target, IID_Position); | this.entity, | ||||||||
| if (!cmpPositionTarget || !cmpPositionTarget.IsInWorld()) | target, | ||||||||
| return false; | range.min, | ||||||||
| parabolicMaxRange, | |||||||||
| let cmpPositionSelf = Engine.QueryInterface(this.entity, IID_Position); | false); | ||||||||
Not Done Inline Actions
Freagarach: | |||||||||
| if (!cmpPositionSelf || !cmpPositionSelf.IsInWorld()) | |||||||||
| return false; | |||||||||
| let positionSelf = cmpPositionSelf.GetPosition(); | |||||||||
| let positionTarget = cmpPositionTarget.GetPosition(); | |||||||||
| let heightDifference = positionSelf.y + range.elevationBonus - positionTarget.y; | |||||||||
| range.max = Math.sqrt(Math.square(range.max) + 2 * range.max * heightDifference); | |||||||||
| if (range.max < 0) | |||||||||
| return false; | |||||||||
| } | |||||||||
| let cmpObstructionManager = Engine.QueryInterface(SYSTEM_ENTITY, IID_ObstructionManager); | |||||||||
| return cmpObstructionManager.IsInTargetRange(this.entity, target, range.min, range.max, false); | |||||||||
| }; | }; | ||||||||
| Attack.prototype.OnValueModification = function(msg) | Attack.prototype.OnValueModification = function(msg) | ||||||||
| { | { | ||||||||
| if (msg.component != "Attack") | if (msg.component != "Attack") | ||||||||
| return; | return; | ||||||||
| let cmpUnitAI = Engine.QueryInterface(this.entity, IID_UnitAI); | let cmpUnitAI = Engine.QueryInterface(this.entity, IID_UnitAI); | ||||||||
| Show All 27 Lines | |||||||||
Wildfire Games · Phabricator
'parabolicMaxRange' is never reassigned. Use 'const' instead.