Page MenuHomeWildfire Games
Differential D3249 Diff 18444 source/simulation2/components/CCmpRangeManager.cpp

Changeset View

Standalone View

View Options

source/simulation2/components/CCmpRangeManager.cpp

Show First 20 Lines • Show All 1,273 Lines • ▼ Show 20 Lines else
continue; continue;
r.push_back(it->first); r.push_back(it->first);
} }
std::sort(r.begin(), r.end()); std::sort(r.begin(), r.end());
} }
} }
virtual entity_pos_t GetEffectiveParabolicRange(entity_id_t source, entity_id_t target, entity_pos_t range, entity_pos_t elevationBonus) const
{
CmpPtr<ICmpPosition> cmpSourcePosition(GetSimContext(), source);
if (!cmpSourcePosition || !cmpSourcePosition->IsInWorld())
return entity_pos_t::FromInt(-1);
vladislavbelovUnsubmitted
Done
Inline Actions

Constant for entity_pos_t::FromInt(-1).

vladislavbelov: Constant for `entity_pos_t::FromInt(-1)`.
CmpPtr<ICmpPosition> cmpTargetPosition(GetSimContext(), target);
if (!cmpTargetPosition || !cmpTargetPosition->IsInWorld())
return entity_pos_t::FromInt(-1);
entity_pos_t h = cmpSourcePosition->GetHeightOffset() - cmpTargetPosition->GetHeightOffset() + elevationBonus;
vladislavbelovUnsubmitted
Done
Inline Actions

const entity_pos_t h = ..., what does the h mean?

vladislavbelov: `const entity_pos_t h = ...`, what does the `h` mean?
if (h < -range / 2)
return entity_pos_t::FromInt(-1);
entity_pos_t r;
bbAuthorUnsubmitted
Done
Inline Actions

This can overflow, do we need to care?

bb: This can overflow, do we need to care?
wraitiiUnsubmitted
Not Done
Inline Actions

I would say yes. The maximal value a fixed can hold is 65536, which is rather low when squaring stuff. A range of 260 will fail, and that doesn't seem outside the range we should support.

wraitii: I would say yes. The maximal value a fixed can hold is 65536, which is rather low when squaring…
vladislavbelovUnsubmitted
Done
Inline Actions

What does the r mean?

vladislavbelov: What does the `r` mean?
r.SetInternalValue(static_cast<i32>(isqrt64(SQUARE_U64_FIXED(range) + static_cast<i64>(h.GetInternalValue()) * 2)));
SilierUnsubmitted
Not Done
Inline Actions

what will be result of isqrt64 from negative number?

Silier: what will be result of isqrt64 from negative number?
bbAuthorUnsubmitted
Done
Inline Actions

As it seems an infinite loop, and hence blatant crash, noone has a clue about why it happened. If we want to fix this, it should be fixed generically in the isqrt64 function (any instance of the function might have this problem). Feel free to create a ticket.

In this case, negative values are protected by the check above.

bb: As it seems an infinite loop, and hence blatant crash, noone has a clue about why it happened.
return r;
}
virtual entity_pos_t GetElevationAdaptedRange(const CFixedVector3D& pos1, const CFixedVector3D& rot, entity_pos_t range, entity_pos_t elevationBonus, entity_pos_t angle) const virtual entity_pos_t GetElevationAdaptedRange(const CFixedVector3D& pos1, const CFixedVector3D& rot, entity_pos_t range, entity_pos_t elevationBonus, entity_pos_t angle) const
{ {
entity_pos_t r = entity_pos_t::Zero(); entity_pos_t r = entity_pos_t::Zero();
CFixedVector3D pos(pos1); CFixedVector3D pos(pos1);
pos.Y += elevationBonus; pos.Y += elevationBonus;
entity_pos_t orientation = rot.Y; entity_pos_t orientation = rot.Y;
▲ Show 20 Lines • Show All 1,212 Lines • Show Last 20 Lines
Wildfire Games · Phabricator