Differential D4240 Diff 18505 binaries/data/mods/public/gui/gamesettings/attributes/MapName.js

Changeset View

Standalone View

binaries/data/mods/public/gui/gamesettings/attributes/MapName.js

	/**			/**
	* Map name.			* Map name.
	* This is usually just the regular map name, but can be overwritten.			* This is usually just the regular map name, but can be overwritten.
	*/			*/
	GameSettings.prototype.Attributes.MapName = class MapName extends GameSetting			GameSettings.prototype.Attributes.MapName = class MapName extends GameSetting
	{			{
	init()			init()
	{			{
				this.isDefault = true;
				this.value = undefined;
				this.settings.map.watch(() => this.updateName(), ["map"]);
	}			}

	toInitAttributes(attribs)			updateName()
	{			{
	if (this.value)			if (this.isDefault)
	attribs.settings.Name = this.value;			this.value = this.settings.map?.data?.settings?.Name \|\| this.settings.map.map;
	else
	{
	// Copy from the map data by default - this helps make InitAttributes self-sufficient,
	// which is nice for replays / saved games.
	wraitiiUnsubmitted Not Done Inline Actions You've lost this particular comment in the rewrite (which I otherwise like), which I think was useful. wraitii: You've lost this particular comment in the rewrite (which I otherwise like), which I think was…
	bbAuthorUnsubmitted Done Inline Actions Don't see how this comment adds anything to the new code. bb: Don't see how this comment adds anything to the new code.
	wraitiiUnsubmitted Not Done Inline Actions One could wonder why the name is always stored when it can be deduced from the map default name. The reason is to simplify replay / saved game parsing. wraitii: One could wonder why the name is always stored when it can be deduced from the map default name.
	// Fallback to the map name to avoid 'undefined' errors.
	attribs.settings.Name = this.settings.map?.data?.settings?.Name \|\| this.settings.map.map;
	}
	}			}

	fromInitAttributes(attribs)			onFinalizeAttributes(attribs)
	{			{
	// Ser/Deser from a different attribute name as a poor man's not-persisted-setting.			attribs.settings.Name = this.value;
	// TODO: split this off more properly.
	if (attribs.mapName)
	this.value = attribs.mapName;
	}			}

	set(name)			setCustom(name)
	{			{
				this.isDefault = false;
	this.value = name;			this.value = name;
	}			}
	};			};