Changeset View
Changeset View
Standalone View
Standalone View
binaries/data/mods/public/gui/lobby/lobby.js
| Show First 20 Lines • Show All 535 Lines • ▼ Show 20 Lines | |||||
| * Do a full update of the player listing, including ratings from cached C++ information. | * Do a full update of the player listing, including ratings from cached C++ information. | ||||
| */ | */ | ||||
| function updatePlayerList() | function updatePlayerList() | ||||
| { | { | ||||
| let playersBox = Engine.GetGUIObjectByName("playersBox"); | let playersBox = Engine.GetGUIObjectByName("playersBox"); | ||||
| let sortBy = playersBox.selected_column || "name"; | let sortBy = playersBox.selected_column || "name"; | ||||
| let sortOrder = playersBox.selected_column_order || 1; | let sortOrder = playersBox.selected_column_order || 1; | ||||
| if (playersBox.selected > -1) | if (playersBox.selected > -1) | ||||
elexis: those 129 characters are a bit long, but not longer than other occurances of this file, and not… | |||||
| g_SelectedPlayer = playersBox.list[playersBox.selected]; | g_SelectedPlayer = playersBox.list[playersBox.selected]; | ||||
| let buddyStatusList = []; | let buddyStatusList = []; | ||||
| let playerList = []; | let playerList = []; | ||||
| let presenceList = []; | let presenceList = []; | ||||
| let nickList = []; | let nickList = []; | ||||
| let ratingList = []; | let ratingList = []; | ||||
| ▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Lines | |||||
| function toggleBuddy() | function toggleBuddy() | ||||
| { | { | ||||
| let playerList = Engine.GetGUIObjectByName("playersBox"); | let playerList = Engine.GetGUIObjectByName("playersBox"); | ||||
| let name = playerList.list[playerList.selected]; | let name = playerList.list[playerList.selected]; | ||||
| if (!name || name == g_Username || name.indexOf(g_BuddyListDelimiter) != -1) | if (!name || name == g_Username || name.indexOf(g_BuddyListDelimiter) != -1) | ||||
| return; | return; | ||||
| let toggleBuddyButton = Engine.GetGUIObjectByName("toggleBuddyButton"); | |||||
| let index = g_Buddies.indexOf(name); | let index = g_Buddies.indexOf(name); | ||||
| toggleBuddyButton.caption = index == -1 ? translate("Unmark as Buddy") : translate("Mark as Buddy"); | |||||
| if (index != -1) | if (index != -1) | ||||
| g_Buddies.splice(index, 1); | g_Buddies.splice(index, 1); | ||||
| else | else | ||||
| g_Buddies.push(name); | g_Buddies.push(name); | ||||
| // Don't save empty strings to the config file | // Don't save empty strings to the config file | ||||
| let buddies = g_Buddies.filter(nick => nick).join(g_BuddyListDelimiter) || g_BuddyListDelimiter; | let buddies = g_Buddies.filter(nick => nick).join(g_BuddyListDelimiter) || g_BuddyListDelimiter; | ||||
| Engine.ConfigDB_CreateValue("user", "lobby.buddies", buddies); | Engine.ConfigDB_CreateValue("user", "lobby.buddies", buddies); | ||||
| ▲ Show 20 Lines • Show All 44 Lines • ▼ Show 20 Lines | for (let i = 0; i < g_GameList.length; ++i) | ||||
| } | } | ||||
| } | } | ||||
| function onPlayerListSelection() | function onPlayerListSelection() | ||||
| { | { | ||||
| lookupSelectedUserProfile("playersBox"); | lookupSelectedUserProfile("playersBox"); | ||||
| let playerList = Engine.GetGUIObjectByName("playersBox"); | let playerList = Engine.GetGUIObjectByName("playersBox"); | ||||
| if (playerList.selected != -1) | let toggleBuddyButton = Engine.GetGUIObjectByName("toggleBuddyButton"); | ||||
| toggleBuddyButton.enabled = !(playerList.selected == -1); | |||||
| if (playerList.selected == -1) | |||||
| return; | |||||
| toggleBuddyButton.caption = playerList.list_buddy[playerList.selected] ? translate("Unmark as Buddy") : translate("Mark as Buddy"); | |||||
| selectGameFromPlayername(playerList.list[playerList.selected]); | selectGameFromPlayername(playerList.list[playerList.selected]); | ||||
| } | } | ||||
| function setLeaderboardVisibility(visible) | function setLeaderboardVisibility(visible) | ||||
| { | { | ||||
| if (visible) | if (visible) | ||||
| Engine.SendGetBoardList(); | Engine.SendGetBoardList(); | ||||
| lookupSelectedUserProfile(visible ? "leaderboardBox" : "playersBox"); | lookupSelectedUserProfile(visible ? "leaderboardBox" : "playersBox"); | ||||
| ▲ Show 20 Lines • Show All 700 Lines • Show Last 20 Lines | |||||
Wildfire Games · Phabricator
those 129 characters are a bit long, but not longer than other occurances of this file, and not much longer than 50% more than the coding convention suggests (80 characters / 120 characters), so ack.
One of the previous version had 159 characters which is definitely too much IMO