Differential D4599 Diff 20093 source/simulation2/components/CCmpUnitMotion.h

Changeset View

Standalone View

source/simulation2/components/CCmpUnitMotion.h

Show First 20 Lines • Show All 511 Lines • ▼ Show 20 Lines	pass_class_t GetPassabilityClass() const override
return m_PassClass;		return m_PassClass;
}		}

std::string GetPassabilityClassName() const override		std::string GetPassabilityClassName() const override
{		{
return m_PassClassName;		return m_PassClassName;
}		}

virtual void SetPassabilityClassName(const std::string& passClassName)		void SetPassabilityClassName(const std::string& passClassName) override
		phositUnsubmitted Done Inline Actions could this be a 'const std::string_view'? phosit: could this be a 'const std::string_view'?
		lyvUnsubmitted Done Inline Actions IIRC, no C++17 yet. And shouldn't it be just `string_view`? lyv: IIRC, no C++17 yet. And shouldn't it be just `string_view`?
		StanAuthorUnsubmitted Done Inline Actions We definitely have C++17. In fact it was one of the big problems when updating Spidermonkey. I'm not confortable with changing this though as I don't know how JSInterfaces would handle that type, if they could at all. Stan: We definitely have C++17. In fact it was one of the big problems when updating Spidermonkey.
{		{
m_PassClassName = passClassName;		m_PassClassName = passClassName;
CmpPtr<ICmpPathfinder> cmpPathfinder(GetSystemEntity());		CmpPtr<ICmpPathfinder> cmpPathfinder(GetSystemEntity());
if (cmpPathfinder)		if (cmpPathfinder)
m_PassClass = cmpPathfinder->GetPassabilityClass(passClassName);		m_PassClass = cmpPathfinder->GetPassabilityClass(passClassName);
}		}

fixed GetCurrentSpeed() const override		fixed GetCurrentSpeed() const override
▲ Show 20 Lines • Show All 1,373 Lines • Show Last 20 Lines