Changeset View
Changeset View
Standalone View
Standalone View
binaries/data/mods/public/gui/options/options.js
Context not available. | |||||
if (data && data.callback) | if (data && data.callback) | ||||
g_HasCallback = true; | g_HasCallback = true; | ||||
g_Controls = {}; | g_Controls = {}; | ||||
g_OptionShown = true; | |||||
var options = Engine.ReadJSONFile("gui/options/options.json"); | var options = Engine.ReadJSONFile("gui/options/options.json"); | ||||
for (let category in options) | for (let category in options) | ||||
Polakrity: `Close without save` and `Save and Close` better? | |||||
Not Done Inline Actions"Keep temporary and close" and "Save and close"? Because it keeps the setted option while game is running until exit. ffffffff: "Keep temporary and close" and "Save and close"?
Because it keeps the setted option while game… | |||||
Not Done Inline Actionsa save and close thing is good but the "no" should be kept too, (It could be more clear to the user what the save button actually does, but out of scope I guess) bb: a save and close thing is good but the "no" should be kept too, (It could be more clear to the… | |||||
Context not available. | |||||
500, 200, | 500, 200, | ||||
translate("You have unsaved changes, do you want to close this window?"), | translate("You have unsaved changes, do you want to close this window?"), | ||||
translate("Warning"), | translate("Warning"), | ||||
[translate("No"), translate("Yes")], | [translate("No"), translate("Yes"), translate("Yes, Save")], | ||||
[null, closePageWithoutConfirmation] | [null, closePageWithoutConfirmation, () => {saveChanges(); closePageWithoutConfirmation(); }] | ||||
bbUnsubmitted Not Done Inline Actionsmultiple statements should be spread over different lines bb: multiple statements should be spread over different lines | |||||
); | ); | ||||
} | } | ||||
else | else | ||||
Context not available. | |||||
Engine.PopGuiPageCB(); | Engine.PopGuiPageCB(); | ||||
else | else | ||||
Engine.PopGuiPage(); | Engine.PopGuiPage(); | ||||
g_OptionShown = false; | |||||
} | } | ||||
Context not available. |
Wildfire Games · Phabricator
Close without save and Save and Close better?