Differential D408 Diff 3283 binaries/data/mods/public/simulation/components/Loot.js

Changeset View

Standalone View

binaries/data/mods/public/simulation/components/Loot.js

	function Loot() {}			function Loot() {}

	Loot.prototype.Schema =			Loot.prototype.Schema =
	"<a:help>Specifies the loot credited when this entity is killed.</a:help>" +			"<a:help>Specifies the loot credited when this entity is killed.</a:help>" +
	"<a:example>" +			"<a:example>" +
	"<xp>35</xp>" +			"<xp>35</xp>" +
	"<metal>10</metal>" +			"<metal>10</metal>" +
	"</a:example>" +			"</a:example>" +
	Resources.BuildSchema("nonNegativeInteger", ["xp"]);			Resources.BuildSchema("nonNegativeInteger", ["xp"]);

	Loot.prototype.Serialize = null; // we have no dynamic state to save			Loot.prototype.Serialize = null; // we have no dynamic state to save

	Loot.prototype.GetXp = function()			Loot.prototype.GetXp = function()
	{			{
	return +(this.template.xp \|\| 0);			return ApplyValueModificationsToEntity("Loot/xp", +(this.template["xp"] \|\| 0), this.entity);
				bbUnsubmitted Not Done Inline Actions `["xp"]` => `.xp` bb: `["xp"]` => `.xp`
	};			};

	Loot.prototype.GetResources = function()			Loot.prototype.GetResources = function()
	{			{
	let ret = {};			let ret = {};
	for (let res of Resources.GetCodes())			for (let res of Resources.GetCodes())
	ret[res] = +(this.template[res] \|\| 0);			ret[res] = ApplyValueModificationsToEntity("Loot/"+res, +(this.template[res] \|\| 0), this.entity);
				elexisUnsubmitted Not Done Inline Actions That sounds like a good idea (need to check if it breaks something) elexis: That sounds like a good idea (need to check if it breaks something)
				fatherbushidoUnsubmitted Not Done Inline Actions As elexis said. Just quickly: why removing "\|\|0", what happens if I multiply a res by 0.7?, does the AI use that or not?, what to do with the structure tree for an autopromoted units? What's the diff between ToEntity and ToTemplate? Isn't there too a Template.js file existing somewhere? fatherbushido: As elexis said. Just quickly: why removing "\|\|0", what happens if I multiply a res by 0.7?
				GrugnasAuthorUnsubmitted Not Done Inline Actions The Structure Tree display promoted units if they replace the considered templates (f.e. have a look at D407 where mercenaries have their basic unit template autopromoted and displayed as promoted in the structure tree). ToEntity sends informations to the single entity rather than the template that could have many entities. In this case, i guess that using ToTemplate would have summed values whenever an unit get promoted. I must admit that removing the \|\| 0 was a forgetfulness, by the way a workaround could be to truncate the result in order to respect the integer value. Grugnas: The Structure Tree display promoted units if they replace the considered templates (f.e. have a…
				fatherbushidoUnsubmitted Not Done Inline Actions Moreover that part is itself problematic enough to be splitted. fatherbushido: Moreover that part is itself problematic enough to be splitted.
				fatherbushidoUnsubmitted Not Done Inline Actions "Loot/Resource/"+res -> "Loot/"+res (or add the optional second param in Template.js -> not the good solution.) And that's the place to round things. (same in Template.js). (As those are integers, see schema). fatherbushido: "Loot/Resource/"+res -> "Loot/"+res (or add the optional second param in Template.js -> not the…
				fatherbushidoUnsubmitted Not Done Inline Actions - ret[res] = ApplyValueModificationsToEntity("Loot/Resource/"+res, +(this.template[res] \|\| 0), this.entity); + ret[res] = ApplyValueModificationsToEntity("Loot/"+res, +(this.template[res] \|\| 0), this.entity); fatherbushido: ``` - ret[res] = ApplyValueModificationsToEntity("Loot/Resource/"+res, +(this.template[res] \|\|…
				bbUnsubmitted Not Done Inline Actions some whitespaces bb: some whitespaces

	return ret;			return ret;
	};			};

	Engine.RegisterComponentType(IID_Loot, "Loot", Loot);			Engine.RegisterComponentType(IID_Loot, "Loot", Loot);