Changeset View
Changeset View
Standalone View
Standalone View
binaries/data/mods/public/gui/session/selection_details.js
Show First 20 Lines • Show All 527 Lines • ▼ Show 20 Lines | function getTradingTooltip(gain) | ||||
if (!gain) | if (!gain) | ||||
return ""; | return ""; | ||||
let markets = [ | let markets = [ | ||||
{ "gain": gain.market1Gain, "owner": gain.market1Owner }, | { "gain": gain.market1Gain, "owner": gain.market1Owner }, | ||||
{ "gain": gain.market2Gain, "owner": gain.market2Owner } | { "gain": gain.market2Gain, "owner": gain.market2Owner } | ||||
]; | ]; | ||||
let primaryGain = gain.traderGain; | let primaryGain = Math.ceil(gain.traderGain/10); | ||||
mimo: why this factor 10? | |||||
GrugnasUnsubmitted Not Done Inline ActionsThe values displayed in the market selection details are 10x the value carried by the trader. ( i recall simeone already mentioning this eventual issue) Grugnas: The values displayed in the market selection details are 10x the value carried by the trader. | |||||
for (let market of markets) | for (let market of markets) | ||||
if (market.gain && market.owner == gain.traderOwner) | if (market.gain && market.owner == gain.traderOwner) | ||||
// Translation: Used in the trading gain tooltip to concatenate profits of different players | // Translation: Used in the trading gain tooltip to concatenate profits of different players | ||||
primaryGain += translate("+") + market.gain; | primaryGain += translate("+") + Math.ceil(market.gain/10); | ||||
let tooltip = tradingGainString(primaryGain, gain.traderOwner); | let tooltip = tradingGainString(primaryGain, gain.traderOwner); | ||||
for (let market of markets) | for (let market of markets) | ||||
if (market.gain && market.owner != gain.traderOwner) | if (market.gain && market.owner != gain.traderOwner) | ||||
tooltip += | tooltip += | ||||
translateWithContext("Separation mark in an enumeration", ", ") + | translateWithContext("Separation mark in an enumeration", ", ") + | ||||
tradingGainString(market.gain, market.owner); | tradingGainString(Math.ceil(market.gain/10), market.owner); | ||||
return tooltip; | return tooltip; | ||||
} | } |
Wildfire Games · Phabricator
why this factor 10?