Differential D754 Diff 4065 binaries/data/mods/public/simulation/data/settings/diplomacy_colors.json

Changeset View

Standalone View

binaries/data/mods/public/simulation/data/settings/diplomacy_colors.json

				{
				"Self": { "r": 0, "g": 0, "b": 255 },
				"Ally": { "r": 0, "g": 255, "b": 0 },
				"Neutral": { "r": 255, "g": 255, "b": 0 },
				"Enemy": { "r": 255, "g": 0, "b": 0 }
				}
				elexisUnsubmitted Done Inline Actions What are 0-8 are doing here that suspiciously look similar but not identical to the player colors? Nuke. elexis: What are 0-8 are doing here that suspiciously look similar but not identical to the player…
				templeAuthorUnsubmitted Done Inline Actions Those are the team colors, what observers see. I think they should be different than regular colors so that it's obvious whether you're using them or not. They're also brighter, which helps units stand out especially on the minimap, and people might use diplomacy colors for that reason alone. "Self" blue isn't the same as player blue, etc. I can remove "0" (gaia) though, I added it only for completeness. temple: Those are the team colors, what observers see. I think they should be different than regular…
				elexisUnsubmitted Not Done Inline Actions Much nicer with those strings. I didn't see read access to these, but in case you want to use these strings and didn't hardcode them in JS or XML, you could, if you want, add a getter that translates to `settings.js`. (Then the strings could be reused in different GUI pages too, which I guess is not relevant for these strings. JFYI.) Also worth to note that `messages.json` is configured to translate strings in JSON files of this directory, but the filenames are hardcoded, so this file is not affected. elexis: Much nicer with those strings. I didn't see read access to these, but in case you want to use…
				elexisUnsubmitted Not Done Inline Actions I'm still a bit dubious about these colors. IMO there should be no color that appears in both player colors and diplo color sets. Otherwise you have more than one guy in the MP chat speaking of the red player that forgot that he had enabled diplo colors and that other players see a different red one. It should become visible to the player if the mode is toggled or not. For instance by indicating that in the GUI button. Can be done separately, but a should-have. Even then, using different colors seems preferable to me. elexis: I'm still a bit dubious about these colors. IMO there should be no color that appears in both…
				templeAuthorUnsubmitted Not Done Inline Actions There's only so many words for colors and we already use eight of them, plus the diplomacy colors won't match unless they're viewing the same player, so it's not a big concern to me. Do you have suggestions for four colors that aren't similar to any player color (and that also don't conflict with resources)? It sounds good to indicate the toggle status in the button. Hopefully an artist will want to improve the placeholder I've made. temple: There's only so many words for colors and we already use eight of them, plus the diplomacy…
				elexisUnsubmitted Not Done Inline Actions Color spectre is limited and nearly fully used yet already, so not much we can do with mere colors. So only using a different concept could counteract. ffm (ticket somewhere) proposed that lines between allies become dashed. But that would solve the problem for territory rendering only. elexis: Color spectre is limited and nearly fully used yet already, so not much we can do with mere…