Changeset View
Changeset View
Standalone View
Standalone View
binaries/data/mods/public/gui/common/global.js
| var g_OptionsShown = false; | |||||
bb: don't use let for globals => var, also `g_OptionsPageShown` would be better imo | |||||
Not Done Inline ActionsOption in plural? Polakrity: Option in plural? | |||||
| function showOptions() | |||||
| { | |||||
| if (!g_OptionsShown) | |||||
| Engine.PushGuiPage("page_options.xml"); | |||||
Done Inline Actionscould you explain the g_ViewedPlayer check? (I don't get why it is required) bb: could you explain the `g_ViewedPlayer` check? (I don't get why it is required) | |||||
Not Done Inline Actionsit was ingame but i ommit ffffffff: it was ingame but i ommit | |||||
| } | |||||
elexisUnsubmitted Not Done Inline ActionsNot a fan of adding global files with 7 lines. Can't we just overwrite the hotkey in the options dialog? elexis: Not a fan of adding global files with 7 lines.
Can't we just overwrite the hotkey in the… | |||||
Wildfire Games · Phabricator
don't use let for globals => var, also g_OptionsPageShown would be better imo